emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

checkpath: add missing sticky/set*id mode bits to check

Browse Source 
We incorrectly masked out the upper 3 bits when checking to see if the
permissions need updating leading us to run chmod when not needed.

Fixes #482.
This commit is contained in:
Mike Frysinger 2023-01-15 15:31:25 -05:00
parent 52dcb4aaa3
commit 6f44445958
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/checkpath/checkpath.c
View File

@ -285,7 +285,7 @@ static int do_check(char *path, uid_t uid, gid_t gid, mode_t mode,
return -1; return -1;
} }
if (mode && (st.st_mode & 0777) != mode) { if (mode && (st.st_mode & 07777) != mode) {
if ((type != inode_dir) && (st.st_nlink > 1)) { if ((type != inode_dir) && (st.st_nlink > 1)) {
eerror("%s: chmod: Too many hard links to %s", applet, path); eerror("%s: chmod: Too many hard links to %s", applet, path);
close(readfd); close(readfd);