emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Libeinfo: do not suppress ewarn() messages"

Browse Source 
This reverts commit 4ee62c7903.

The previously referenced commit broke consistency because ewarnx() was
respecting the EINFO_QUIET environment setting, but after this commit,
ewarn() was not.
Also, due to discussion on the below referenced bugs, I think we do
want to suppress warnings when EINFO_QUIET=yes.

X-Gentoo-Bug: 482396
X-Gentoo-Bug: 439174
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=482396
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=439174
This commit is contained in:
William Hubbs 2013-08-26 14:31:34 -05:00
parent 5c3e5d801b
commit 72b58b9e6b
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
man/einfo.3
View File

@ -105,7 +105,8 @@ and
respectively, but only work when respectively, but only work when
.Va EINFO_VERBOSE .Va EINFO_VERBOSE
is true. You can also make the is true. You can also make the
.Fn einfo .Fn einfo ,
.Fn ewarn ,
and and
.Fn ebegin .Fn ebegin
functions silent by setting functions silent by setting

2
src/libeinfo/libeinfo.c
View File

@ -705,7 +705,7 @@ ewarn(const char *EINFO_RESTRICT fmt, ...)
int retval; int retval;
va_list ap; va_list ap;
if (!fmt) if (!fmt || is_quiet())
return 0; return 0;
va_start(ap, fmt); va_start(ap, fmt);
elogv(LOG_WARNING, fmt, ap); elogv(LOG_WARNING, fmt, ap);