emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

broadcast: fix compiler warnings

Browse Source 
Newer gcc reports:
broadcast.c: In function 'broadcast':
broadcast.c:132:15: warning: variable 'tp' might be clobbered by 'longjmp' or 'vfork' [-Wclobbered]
  132 |         FILE *tp;

Move the storage off the stack to avoid.  This makes the function
not safe for multithread use, but we don't do that anywhere, so
who cares!
This commit is contained in:
Mike Frysinger 2021-12-21 01:46:19 -05:00
parent 8ffc4162e2
commit 8b247dd5d8
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/rc/broadcast.c
View File

@ -117,6 +117,8 @@ static int file_isatty(const char *fname)
/* /*
* broadcast function. * broadcast function.
*
* NB: Not multithread safe.
*/ */
void broadcast(char *text) void broadcast(char *text)
{ {
@ -128,11 +130,15 @@ void broadcast(char *text)
char *p; char *p;
char *line = NULL; char *line = NULL;
struct sigaction sa; struct sigaction sa;
volatile int fd;
FILE *tp;
int flags; int flags;
char *term = NULL; char *term = NULL;
struct utmpx *utmp; struct utmpx *utmp;
/*
* These are set across the sigsetjmp call, so they can't be stored on
* the stack, otherwise they might be clobbered.
*/
static int fd;
static FILE *tp;
getuidtty(&user, &tty); getuidtty(&user, &tty);