emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: tweak end-of-job processing if invoked via signal

Browse Source 
The master branch top is pretty well insulated against
signal-unsafe function calls during end-of-job action.

However, this newlib branch top had exposed himself to
a bunch of such unsafe activity in the form of 'unref'
function calls to the new library. In those guys there
will be several 'free' invocations which are not safe.

So, this commit will simply correct such an oversight.

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2021-09-16 00:00:00 -05:00 committed by Craig Small
parent 6049c13b4d
commit 1d1c1b84df
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
top/top.c
View File

@ -417,9 +417,12 @@ static void bye_bye (const char *str) {
} }
#endif // end: ATEOJ_RPTSTD #endif // end: ATEOJ_RPTSTD
procps_meminfo_unref(&Mem_ctx); // there's lots of signal-unsafe stuff in the following ...
if (Frames_signal != BREAK_sig) {
procps_pids_unref(&Pids_ctx); procps_pids_unref(&Pids_ctx);
procps_stat_unref(&Stat_ctx); procps_stat_unref(&Stat_ctx);
procps_meminfo_unref(&Mem_ctx);
}
/* we'll only have a 'str' if called by error_exit() | /* we'll only have a 'str' if called by error_exit() |
not ever from the sig_endpgm() signal handler ... | */ not ever from the sig_endpgm() signal handler ... | */
@ -444,6 +447,7 @@ static void error_exit (const char *str) __attribute__((__noreturn__));
static void error_exit (const char *str) { static void error_exit (const char *str) {
static char buf[MEDBUFSIZ]; static char buf[MEDBUFSIZ];
Frames_signal = BREAK_off;
/* we'll use our own buffer so callers can still use fmtmk() and, after /* we'll use our own buffer so callers can still use fmtmk() and, after
twelve long years, 2013 was the year we finally eliminated the leading twelve long years, 2013 was the year we finally eliminated the leading
tab character -- now our message can get lost in screen clutter too! */ tab character -- now our message can get lost in screen clutter too! */