emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: improve unsolicited user input validation

Browse Source 
The logic associated with invalid keystrokes was
simplified through some minor reordering.

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2012-06-30 00:00:33 -05:00 committed by Craig Small
parent fbfaa868ba
commit 22515ce62e
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
top/top.c
View File

@ -3488,16 +3488,11 @@ static void do_key (int ch) {
for (i = 0; i < MAXTBL(key_tab); ++i) for (i = 0; i < MAXTBL(key_tab); ++i)
if (strchr(key_tab[i].keys, ch)) { if (strchr(key_tab[i].keys, ch)) {
key_tab[i].func(ch); key_tab[i].func(ch);
break; Frames_resize = 1;
}
if (!(i < MAXTBL(key_tab))) {
show_msg(N_txt(UNKNOWN_cmds_txt));
return; return;
} }
}; };
/* Frames_resize above will force a rebuild of all column headers and
/* The following assignment will force a rebuild of all column headers and
the PROC_FILLxxx flags. It's NOT simply lazy programming. Here are the PROC_FILLxxx flags. It's NOT simply lazy programming. Here are
some keys that COULD require new column headers and/or libproc flags: some keys that COULD require new column headers and/or libproc flags:
'A' - likely 'A' - likely
@ -3516,7 +3511,8 @@ static void do_key (int ch) {
( At this point we have a human being involved and so have all the time ) ( At this point we have a human being involved and so have all the time )
( in the world. We can afford a few extra cpu cycles every now & then! ) ( in the world. We can afford a few extra cpu cycles every now & then! )
*/ */
Frames_resize = 1;
show_msg(N_txt(UNKNOWN_cmds_txt));
} // end: do_key } // end: do_key