emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

library: strengthen <pids> sort order parameter checks

Browse Source 
The way that the passed sort order was validated would
allow the invalid 0 to fall between the sofa cushions.
So this patch will simply close that former oversight.

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2015-09-28 00:00:00 -05:00 committed by Craig Small
parent 683b3fd4f2
commit 27283bbc6f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proc/pids.c
View File

@ -1389,7 +1389,7 @@ PROCPS_EXPORT struct pids_stack **procps_pids_stacks_sort (
// a pids_item is currently unsigned, but we'll protect our future // a pids_item is currently unsigned, but we'll protect our future
if (sort < 0 || sort > PROCPS_PIDS_noop) if (sort < 0 || sort > PROCPS_PIDS_noop)
return NULL; return NULL;
if (order < -1 || order > +1) if (order != PROCPS_SORT_ASCEND && order != PROCPS_SORT_DESCEND)
return NULL; return NULL;
if (numstacked < 2) if (numstacked < 2)
return stacks; return stacks;