emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

procio: use the user-supplied delimiter to split large input

Browse Source 
The `fprocopen` function allows users to specify a delimiter chacter
that is used to split very large input lines into smaller chunks. While
the code checks that the caller did actually supply the delimiter, it is
in fact never used to split the string. Instead, the hardcoded default
character ',' is always used to split the string.

Fix the issue by using `cookie->delim` instead.
This commit is contained in:
Patrick Steinhardt 2018-06-08 13:27:20 +02:00 committed by Craig Small
parent 9b9aa9a6e9
commit 32720b2ee6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
procio.c
View File

@ -249,7 +249,7 @@ ssize_t proc_write(void *c, const char *buf, size_t count)
do { do {
token = NULL; token = NULL;
if (cookie->offset > LINELEN) if (cookie->offset > LINELEN)
token = (char*)memrchr(cookie->buf+offset, ',', LINELEN); token = (char*)memrchr(cookie->buf+offset, cookie->delim, LINELEN);
else else
token = (char*)memrchr(cookie->buf+offset, '\n', LINELEN); token = (char*)memrchr(cookie->buf+offset, '\n', LINELEN);
if (token) if (token)