emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: prevent buffer overruns in 'inspection_utility()'

Browse Source 
When a Qualys patch was reverted as being unwarranted,
1 specific problem their patch had, in fact, prevented
was re-introduced. This patch corrects that oversight.

Reference(s):
. qualys patch revert
commit c502678715

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2018-05-24 00:00:00 -05:00 committed by Craig Small
parent a42742b0df
commit 434530a038
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
top/top.c
View File

@ -3468,8 +3468,8 @@ static void inspection_utility (int pid) {
Inspect.tab[sel].caps = "~4"; dst[0] = '\0'; \ Inspect.tab[sel].caps = "~4"; dst[0] = '\0'; \
for (i = 0; i < Inspect.total; i++) { char _s[SMLBUFSIZ]; \ for (i = 0; i < Inspect.total; i++) { char _s[SMLBUFSIZ]; \
snprintf(_s, sizeof(_s), " %s %s", Inspect.tab[i].name, Inspect.tab[i].caps); \ snprintf(_s, sizeof(_s), " %s %s", Inspect.tab[i].name, Inspect.tab[i].caps); \
strcat(dst, _s); } } strncat(dst, _s, (sizeof(dst) - 1) - strlen(dst)); } }
char sels[MEDBUFSIZ]; char sels[SCREENMAX];
static int sel; static int sel;
int i, key; int i, key;
proc_t *p; proc_t *p;