top: Do not default to the cwd in configs_r... Tweaked
While it's only documented (so far) in commit text and an occasional email I've tried to maintain some coding standards primarily for reference/navigation purposes. They also served, I felt, as useful mental challenges. Someday I will get around to formerly documenting them but in the meantime here are the ones for this commit: . functions are grouped into logical (i hope) sections . functions & sections are ordered to avoid prototypes . function names are alphabetical within every section . all functions & sections must be referenced in top.h This patch just attempts to honor the above standards, while also covering this new behavior in the man page. [ please note that the net result of these 2 patches ] [ is simply to avoid pathname truncations should our ] [ limit of 1024 be exceeded. they do not have a role ] [ in solving the 'local privilege escalation' issue. ] [ and we can never prevent a user from setting their ] [ HOME var to a directory writable by some attacker! ] [ the only real protection for that CVE-2018-1122 is ] [ those soon to be enhanced rcfile integrity checks, ] [ achieved through several of the following patches. ] Reference(s): . original qualys patch 0097-top-Do-not-default-to-the-cwd-in-configs_read.patch Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
@@ -624,7 +624,8 @@ typedef struct WIN_t {
|
||||
//atic void before (char *me);
|
||||
//atic int config_cvt (WIN_t *q);
|
||||
//atic const char *config_file (FILE *fp, const char *name, float *delay);
|
||||
//atic void configs_read (void);
|
||||
//atic int configs_path (const char *const fmts, ...);
|
||||
//atic void configs_reads (void);
|
||||
//atic void parse_args (char **args);
|
||||
//atic void whack_terminal (void);
|
||||
/*------ Windows/Field Groups support ----------------------------------*/
|
||||
|
Reference in New Issue
Block a user