emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

0061-ps/output.c: Always null-terminate outbuf in show_one_proc().

Browse Source 
Before "strlen(outbuf)", if one of the pr_*() functions forgot to do it.
This prevents an out-of-bounds read in strlen(), and an out-of-bounds
write in "outbuf[sz] = '\n'". Another solution would be to replace
strlen() with strnlen(), but this is not used anywhere else in the
code-base and may not exist in all libc's.

---------------------------- adapted for newlib branch
. adapted via 'patch' without rejections

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent c5bbe00770
commit 6f7d610621
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ps/output.c
View File

@ -2027,6 +2027,7 @@ void show_one_proc(const proc_t *restrict const p, const format_node *restrict f
if(space>SPACE_AMOUNT) space=SPACE_AMOUNT; // only so much available if(space>SPACE_AMOUNT) space=SPACE_AMOUNT; // only so much available
/* real size -- don't forget in 'amount' is number of cells */ /* real size -- don't forget in 'amount' is number of cells */
outbuf[OUTBUF_SIZE-1] = '\0';
sz = strlen(outbuf); sz = strlen(outbuf);
/* print data, set x position stuff */ /* print data, set x position stuff */