emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

0100-top: Check Rc.fixed_widest.

Browse Source 
Otherwise it leads to crashes (for example, setting it to 2147483600 in
the configuration file segfaults top).
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent 0b0356de5c
commit 766e31a2c3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
top/top.c
View File

@ -3285,6 +3285,8 @@ error Hey, fix the above fscanf 'PFLAGSSIZ' dependency !
if (fscanf(fp, "Fixed_widest=%d, Summ_mscale=%d, Task_mscale=%d, Zero_suppress=%d\n" if (fscanf(fp, "Fixed_widest=%d, Summ_mscale=%d, Task_mscale=%d, Zero_suppress=%d\n"
, &Rc.fixed_widest, &Rc.summ_mscale, &Rc.task_mscale, &Rc.zero_suppress)) , &Rc.fixed_widest, &Rc.summ_mscale, &Rc.task_mscale, &Rc.zero_suppress))
; // avoid -Wunused-result ; // avoid -Wunused-result
if (Rc.fixed_widest < -1 || Rc.fixed_widest > SCREENMAX)
Rc.fixed_widest = 0;
// we'll start off Inspect stuff with 1 'potential' blank line // we'll start off Inspect stuff with 1 'potential' blank line
// ( only realized if we end up with Inspect.total > 0 ) // ( only realized if we end up with Inspect.total > 0 )
@ -4319,7 +4321,7 @@ static void keys_global (int ch) {
case 'X': case 'X':
{ int wide = get_int(fmtmk(N_fmt(XTRA_fixwide_fmt), Rc.fixed_widest)); { int wide = get_int(fmtmk(N_fmt(XTRA_fixwide_fmt), Rc.fixed_widest));
if (wide > GET_NUM_NOT) { if (wide > GET_NUM_NOT) {
if (wide > -1) Rc.fixed_widest = wide; if (wide >= 0 && wide <= SCREENMAX) Rc.fixed_widest = wide;
else Rc.fixed_widest = -1; else Rc.fixed_widest = -1;
} }
} }