emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: fix a bug from when 'Ctrl' window was made sticky

Browse Source 
In the patch referenced below the bottom 'Ctrl' window
was made to remain until it was dismissed by the user.

As such, it required abandoning a 'Cap_nl_clreos' used
when all the terminal rows had not been drawn. Instead
each line had to be cleared individually until the row
reserved for that 'Ctrl' window area had been reached.

Unfortunately, while a 'Cap_nl_clreos' didn't create a
problem for 'batch' mode, a 'Cap_clr_eol' used instead
yielded an unending loop if those rows were limitless.

So, now we will only clear that area when top isn't in
'batch' mode (which should have always been the case).

Reference(s):
. May, 2022 - bottom window made sticky
commit 0f2a755b0b

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2022-05-05 00:00:00 -05:00 committed by Craig Small
parent 9dd75a4ac8
commit 793f3e85ae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
top/top.c
View File

@ -6833,7 +6833,7 @@ static void frame_make (void) {
/* clear to end-of-screen - critical if last window is 'idleps off' /* clear to end-of-screen - critical if last window is 'idleps off'
(main loop must iterate such that we're always called before sleep) */ (main loop must iterate such that we're always called before sleep) */
if (scrlins < Max_lines) { if (!Batch && scrlins < Max_lines) {
for (i = scrlins + Msg_row + 1; i < SCREEN_ROWS; i++) { for (i = scrlins + Msg_row + 1; i < SCREEN_ROWS; i++) {
putp(tg2(0, i)); putp(tg2(0, i));
putp(Cap_clr_eol); putp(Cap_clr_eol);