emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

skill: Simplify the kill_main() loop.

Browse Source 
Right now the "loop=0; break;" is never reached.
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent daec51a06c
commit 7d6977b6f7
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
skill.c
View File

@ -419,7 +419,6 @@ static void __attribute__ ((__noreturn__))
kill_main(int argc, char **argv) kill_main(int argc, char **argv)
{ {
int signo, i; int signo, i;
int loop = 1;
long pid; long pid;
int exitvalue = EXIT_SUCCESS; int exitvalue = EXIT_SUCCESS;
char *sig_option; char *sig_option;
@ -446,7 +445,7 @@ static void __attribute__ ((__noreturn__))
signo = SIGTERM; signo = SIGTERM;
opterr=0; /* suppress errors on -123 */ opterr=0; /* suppress errors on -123 */
while (loop == 1 && (i = getopt_long(argc, argv, "l::Ls:hV", longopts, NULL)) != -1) while ((i = getopt_long(argc, argv, "l::Ls:hV", longopts, NULL)) != -1)
switch (i) { switch (i) {
case 'l': case 'l':
sig_option = NULL; sig_option = NULL;
@ -491,8 +490,7 @@ static void __attribute__ ((__noreturn__))
exitvalue = EXIT_FAILURE; exitvalue = EXIT_FAILURE;
exit(exitvalue); exit(exitvalue);
} }
loop=0; xerrx(EXIT_FAILURE, _("internal error"));
break;
default: default:
kill_usage(stderr); kill_usage(stderr);
} }