sysctl: fix coding style
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola
parent
1cde286c75
commit
8fe81caa42
194
sysctl.c
194
sysctl.c
@ -1,16 +1,13 @@
|
||||
|
||||
/*
|
||||
* Sysctl 1.01 - A utility to read and manipulate the sysctl parameters
|
||||
*
|
||||
*
|
||||
* "Copyright 1999 George Staikos
|
||||
* This file may be used subject to the terms and conditions of the
|
||||
* GNU General Public License Version 2, or any later version
|
||||
* at your option, as published by the Free Software Foundation.
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details."
|
||||
* This file may be used subject to the terms and conditions of the GNU
|
||||
* General Public License Version 2, or any later version at your option, as
|
||||
* published by the Free Software Foundation. This program is distributed in
|
||||
* the hope that it will be useful, but WITHOUT ANY WARRANTY; without even
|
||||
* the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
|
||||
* PURPOSE. See the GNU General Public License for more details."
|
||||
*
|
||||
* Changelog:
|
||||
* v1.01:
|
||||
@ -21,7 +18,6 @@
|
||||
* Changes by Albert Cahalan, 2002.
|
||||
*/
|
||||
|
||||
|
||||
#include <dirent.h>
|
||||
#include <errno.h>
|
||||
#include <getopt.h>
|
||||
@ -41,7 +37,6 @@
|
||||
#include "proc/procps.h"
|
||||
#include "proc/version.h"
|
||||
|
||||
|
||||
/* Proof that C++ causes brain damage: */
|
||||
typedef int bool;
|
||||
static bool true = 1;
|
||||
@ -50,7 +45,6 @@ static bool false = 0;
|
||||
/*
|
||||
* Globals...
|
||||
*/
|
||||
|
||||
static const char PROC_PATH[] = "/proc/sys/";
|
||||
static const char DEFAULT_PRELOAD[] = "/etc/sysctl.conf";
|
||||
static bool NameOnly;
|
||||
@ -60,37 +54,44 @@ static bool IgnoreError;
|
||||
static bool Quiet;
|
||||
static char *pattern;
|
||||
|
||||
/* Function prototypes. */
|
||||
static int pattern_match(const char *string, const char *pattern);
|
||||
static int DisplayAll(const char *restrict const path);
|
||||
|
||||
static void slashdot(char *restrict p, char old, char new){
|
||||
static void slashdot(char *restrict p, char old, char new)
|
||||
{
|
||||
int warned = 1;
|
||||
p = strpbrk(p, "/.");
|
||||
if(!p) return; /* nothing -- can't be, but oh well */
|
||||
if(*p==new) return; /* already in desired format */
|
||||
if (!p)
|
||||
/* nothing -- can't be, but oh well */
|
||||
return;
|
||||
if (*p == new)
|
||||
/* already in desired format */
|
||||
return;
|
||||
while (p) {
|
||||
char c = *p;
|
||||
if ((*(p + 1) == '/' || *(p + 1) == '.') && warned) {
|
||||
xwarnx(_("separators should not be repeated: %s"), p);
|
||||
warned = 0;
|
||||
}
|
||||
if(c==old) *p=new;
|
||||
if(c==new) *p=old;
|
||||
if (c == old)
|
||||
*p = new;
|
||||
if (c == new)
|
||||
*p = old;
|
||||
p = strpbrk(p + 1, "/.");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
|
||||
/*
|
||||
* Display the usage format
|
||||
*
|
||||
*/
|
||||
static void __attribute__ ((__noreturn__))
|
||||
Usage(FILE * out)
|
||||
{
|
||||
fputs(USAGE_HEADER, out);
|
||||
fprintf(out,
|
||||
_(" %s [options] [variable[=value] ...]\n"), program_invocation_short_name);
|
||||
_(" %s [options] [variable[=value] ...]\n"),
|
||||
program_invocation_short_name);
|
||||
fputs(USAGE_OPTIONS, out);
|
||||
fputs(_(" -a, --all display all variables\n"
|
||||
" -A alias of -a\n"
|
||||
@ -119,9 +120,9 @@ static void __attribute__ ((__noreturn__))
|
||||
|
||||
/*
|
||||
* Strip the leading and trailing spaces from a string
|
||||
*
|
||||
*/
|
||||
static char *StripLeadingAndTrailingSpaces(char *oneline) {
|
||||
static char *StripLeadingAndTrailingSpaces(char *oneline)
|
||||
{
|
||||
char *t;
|
||||
|
||||
if (!oneline || !*oneline)
|
||||
@ -141,13 +142,11 @@ static char *StripLeadingAndTrailingSpaces(char *oneline) {
|
||||
return t;
|
||||
}
|
||||
|
||||
static int DisplayAll(const char *restrict const path);
|
||||
|
||||
/*
|
||||
* Read a sysctl setting
|
||||
*
|
||||
*/
|
||||
static int ReadSetting(const char *restrict const name) {
|
||||
static int ReadSetting(const char *restrict const name)
|
||||
{
|
||||
int rc = 0;
|
||||
char *restrict tmpname;
|
||||
char *restrict outname;
|
||||
@ -162,17 +161,20 @@ static int ReadSetting(const char *restrict const name) {
|
||||
|
||||
/* used to display the output */
|
||||
outname = xstrdup(name);
|
||||
slashdot(outname,'/','.'); /* change / to . */
|
||||
/* change / to . */
|
||||
slashdot(outname, '/', '.');
|
||||
|
||||
/* used to open the file */
|
||||
tmpname = xmalloc(strlen(name) + strlen(PROC_PATH) + 2);
|
||||
strcpy(tmpname, PROC_PATH);
|
||||
strcat(tmpname, name);
|
||||
slashdot(tmpname+strlen(PROC_PATH),'.','/'); /* change . to / */
|
||||
/* change . to / */
|
||||
slashdot(tmpname + strlen(PROC_PATH), '.', '/');
|
||||
|
||||
/* used to display the output */
|
||||
outname = xstrdup(name);
|
||||
slashdot(outname,'/','.'); /* change / to . */
|
||||
/* change / to . */
|
||||
slashdot(outname, '/', '.');
|
||||
|
||||
if (stat(tmpname, &ts) < 0) {
|
||||
if (!IgnoreError) {
|
||||
@ -220,19 +222,23 @@ static int ReadSetting(const char *restrict const name) {
|
||||
} else {
|
||||
errno = 0;
|
||||
if (fgets(inbuf, sizeof inbuf - 1, fp)) {
|
||||
// this loop is required, see
|
||||
// /sbin/sysctl -a | egrep -6 dev.cdrom.info
|
||||
/* this loop is required, see
|
||||
* /sbin/sysctl -a | egrep -6 dev.cdrom.info
|
||||
*/
|
||||
do {
|
||||
if (NameOnly) {
|
||||
fprintf(stdout, "%s\n", outname);
|
||||
} else {
|
||||
/* already has the \n in it */
|
||||
if (PrintName) {
|
||||
fprintf(stdout, "%s = %s", outname, inbuf);
|
||||
fprintf(stdout, "%s = %s",
|
||||
outname, inbuf);
|
||||
} else {
|
||||
if (!PrintNewline) {
|
||||
char *nlptr = strchr(inbuf,'\n');
|
||||
if(nlptr) *nlptr='\0';
|
||||
char *nlptr =
|
||||
strchr(inbuf, '\n');
|
||||
if (nlptr)
|
||||
*nlptr = '\0';
|
||||
}
|
||||
fprintf(stdout, "%s", inbuf);
|
||||
}
|
||||
@ -241,7 +247,8 @@ static int ReadSetting(const char *restrict const name) {
|
||||
} else {
|
||||
switch (errno) {
|
||||
case EACCES:
|
||||
xwarnx(_("permission denied on key '%s'"), outname);
|
||||
xwarnx(_("permission denied on key '%s'"),
|
||||
outname);
|
||||
rc = -1;
|
||||
break;
|
||||
case EISDIR: {
|
||||
@ -268,13 +275,11 @@ out:
|
||||
return rc;
|
||||
}
|
||||
|
||||
|
||||
|
||||
/*
|
||||
* Display all the sysctl settings
|
||||
*
|
||||
*/
|
||||
static int DisplayAll(const char *restrict const path) {
|
||||
static int DisplayAll(const char *restrict const path)
|
||||
{
|
||||
int rc = 0;
|
||||
int rc2;
|
||||
DIR *restrict dp;
|
||||
@ -287,11 +292,14 @@ static int DisplayAll(const char *restrict const path) {
|
||||
xwarnx(_("unable to open directory \"%s\""), path);
|
||||
rc = -1;
|
||||
} else {
|
||||
readdir(dp); // skip .
|
||||
readdir(dp); // skip ..
|
||||
readdir(dp); /* skip . */
|
||||
readdir(dp); /* skip .. */
|
||||
while ((de = readdir(dp))) {
|
||||
char *restrict tmpdir;
|
||||
tmpdir = (char *restrict)xmalloc(strlen(path)+strlen(de->d_name)+2);
|
||||
tmpdir =
|
||||
(char *restrict) xmalloc(strlen(path) +
|
||||
strlen(de->d_name) +
|
||||
2);
|
||||
sprintf(tmpdir, "%s%s", path, de->d_name);
|
||||
rc2 = stat(tmpdir, &ts);
|
||||
if (rc2 != 0) {
|
||||
@ -301,7 +309,9 @@ static int DisplayAll(const char *restrict const path) {
|
||||
strcat(tmpdir, "/");
|
||||
DisplayAll(tmpdir);
|
||||
} else {
|
||||
rc |= ReadSetting(tmpdir+strlen(PROC_PATH));
|
||||
rc |=
|
||||
ReadSetting(tmpdir +
|
||||
strlen(PROC_PATH));
|
||||
}
|
||||
}
|
||||
free(tmpdir);
|
||||
@ -311,12 +321,11 @@ static int DisplayAll(const char *restrict const path) {
|
||||
return rc;
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* Write a sysctl setting
|
||||
*
|
||||
*/
|
||||
static int WriteSetting(const char *setting) {
|
||||
static int WriteSetting(const char *setting)
|
||||
{
|
||||
int rc = 0;
|
||||
const char *name = setting;
|
||||
const char *value;
|
||||
@ -326,18 +335,20 @@ static int WriteSetting(const char *setting) {
|
||||
FILE *fp;
|
||||
struct stat ts;
|
||||
|
||||
if (!name) { /* probably don't want to display this err */
|
||||
if (!name)
|
||||
/* probably don't want to display this err */
|
||||
return 0;
|
||||
} /* end if */
|
||||
|
||||
equals = strchr(setting, '=');
|
||||
|
||||
if (!equals) {
|
||||
xwarnx(_("\"%s\" must be of the form name=value"), setting);
|
||||
xwarnx(_("\"%s\" must be of the form name=value"),
|
||||
setting);
|
||||
return -1;
|
||||
}
|
||||
|
||||
value = equals + 1; /* point to the value in name=value */
|
||||
/* point to the value in name=value */
|
||||
value = equals + 1;
|
||||
|
||||
if (!*name || !*value || name == equals) {
|
||||
xwarnx(_("malformed setting \"%s\""), setting);
|
||||
@ -349,13 +360,15 @@ static int WriteSetting(const char *setting) {
|
||||
strcpy(tmpname, PROC_PATH);
|
||||
strncat(tmpname, name, (int) (equals - name));
|
||||
tmpname[equals - name + strlen(PROC_PATH)] = 0;
|
||||
slashdot(tmpname+strlen(PROC_PATH),'.','/'); /* change . to / */
|
||||
/* change . to / */
|
||||
slashdot(tmpname + strlen(PROC_PATH), '.', '/');
|
||||
|
||||
/* used to display the output */
|
||||
outname = xmalloc(equals - name + 1);
|
||||
strncpy(outname, name, (int) (equals - name));
|
||||
outname[equals - name] = 0;
|
||||
slashdot(outname,'/','.'); /* change / to . */
|
||||
/* change / to . */
|
||||
slashdot(outname, '/', '.');
|
||||
|
||||
if (stat(tmpname, &ts) < 0) {
|
||||
if (!IgnoreError) {
|
||||
@ -409,7 +422,8 @@ static int WriteSetting(const char *setting) {
|
||||
fprintf(stdout, "%s\n", outname);
|
||||
} else {
|
||||
if (PrintName) {
|
||||
fprintf(stdout, "%s = %s\n", outname, value);
|
||||
fprintf(stdout, "%s = %s\n",
|
||||
outname, value);
|
||||
} else {
|
||||
if (PrintNewline)
|
||||
fprintf(stdout, "%s\n", value);
|
||||
@ -430,23 +444,21 @@ static int pattern_match(const char *string, const char *pattern)
|
||||
int status;
|
||||
regex_t re;
|
||||
|
||||
if (regcomp(&re, pattern, REG_EXTENDED | REG_NOSUB) != 0) {
|
||||
return (0); /* Report error. */
|
||||
}
|
||||
if (regcomp(&re, pattern, REG_EXTENDED | REG_NOSUB) != 0)
|
||||
return (0);
|
||||
status = regexec(&re, string, (size_t) 0, NULL, 0);
|
||||
regfree(&re);
|
||||
if (status != 0) {
|
||||
return (0); /* Report error. */
|
||||
}
|
||||
if (status != 0)
|
||||
return (0);
|
||||
return (1);
|
||||
}
|
||||
|
||||
/*
|
||||
* Preload the sysctl's from the conf file
|
||||
* - we parse the file and then reform it (strip out whitespace)
|
||||
*
|
||||
* Preload the sysctl's from the conf file. We parse the file and then
|
||||
* reform it (strip out whitespace).
|
||||
*/
|
||||
static int Preload(const char *restrict const filename) {
|
||||
static int Preload(const char *restrict const filename)
|
||||
{
|
||||
char oneline[256];
|
||||
char buffer[256];
|
||||
FILE *fp;
|
||||
@ -456,9 +468,7 @@ static int Preload(const char *restrict const filename) {
|
||||
char *name, *value;
|
||||
|
||||
fp = (filename[0] == '-' && !filename[1])
|
||||
? stdin
|
||||
: fopen(filename, "r")
|
||||
;
|
||||
? stdin : fopen(filename, "r");
|
||||
|
||||
if (!fp) {
|
||||
xwarn(_("cannot open \"%s\""), filename);
|
||||
@ -477,26 +487,27 @@ static int Preload(const char *restrict const filename) {
|
||||
|
||||
name = strtok(t, "=");
|
||||
if (!name || !*name) {
|
||||
xwarnx(_("%s(%d): invalid syntax, continuing..."), filename, n);
|
||||
xwarnx(_("%s(%d): invalid syntax, continuing..."),
|
||||
filename, n);
|
||||
continue;
|
||||
}
|
||||
|
||||
StripLeadingAndTrailingSpaces(name);
|
||||
|
||||
if (pattern && !pattern_match(name, pattern)){
|
||||
if (pattern && !pattern_match(name, pattern))
|
||||
continue;
|
||||
}
|
||||
|
||||
value = strtok(NULL, "\n\r");
|
||||
if (!value || !*value) {
|
||||
xwarnx(_("%s(%d): invalid syntax, continuing..."), filename, n);
|
||||
xwarnx(_("%s(%d): invalid syntax, continuing..."),
|
||||
filename, n);
|
||||
continue;
|
||||
}
|
||||
|
||||
while ((*value == ' ' || *value == '\t') && *value != 0)
|
||||
value++;
|
||||
|
||||
// should NameOnly affect this?
|
||||
/* should NameOnly affect this? */
|
||||
sprintf(buffer, "%s=%s", name, value);
|
||||
rc |= WriteSetting(buffer);
|
||||
}
|
||||
@ -517,7 +528,8 @@ static int sortpairs(const void* A, const void* B)
|
||||
return strcmp(a->name, b->name);
|
||||
}
|
||||
|
||||
static int PreloadSystem(void) {
|
||||
static int PreloadSystem(void)
|
||||
{
|
||||
unsigned di, i;
|
||||
const char *dirs[] = {
|
||||
"/run/sysctl.d",
|
||||
@ -535,27 +547,33 @@ static int PreloadSystem(void) {
|
||||
DIR *dp = opendir(dirs[di]);
|
||||
if (!dp)
|
||||
continue;
|
||||
|
||||
while ((de = readdir(dp))) {
|
||||
if (!strcmp(de->d_name, ".") || !strcmp(de->d_name, "..")) {
|
||||
if (!strcmp(de->d_name, ".")
|
||||
|| !strcmp(de->d_name, ".."))
|
||||
continue;
|
||||
}
|
||||
if (strlen(de->d_name) < 6 || !strcmp(de->d_name+strlen(de->d_name)-6, ".conf"))
|
||||
if (strlen(de->d_name) < 6
|
||||
|| !strcmp(de->d_name + strlen(de->d_name) - 6, ".conf"))
|
||||
continue;
|
||||
/* check if config already known */
|
||||
for (i = 0; i < ncfgs; ++i) {
|
||||
if (!strcmp(cfgs[i]->name, de->d_name))
|
||||
break;
|
||||
}
|
||||
if (i < ncfgs) // already in
|
||||
if (i < ncfgs)
|
||||
/* already in */
|
||||
continue;
|
||||
|
||||
if (ncfgs % nprealloc == 0) {
|
||||
if (ncfgs % nprealloc == 0)
|
||||
cfgs = xrealloc(cfgs, sizeof(struct pair *) * (ncfgs + nprealloc));
|
||||
}
|
||||
cfgs[ncfgs] = xmalloc(sizeof(struct pair) + strlen(de->d_name)*2+2 + strlen(dirs[di])+1);
|
||||
cfgs[ncfgs] =
|
||||
xmalloc(sizeof(struct pair) + strlen(de->d_name) * 2 + 2 +
|
||||
strlen(dirs[di]) + 1);
|
||||
cfgs[ncfgs]->name = (char *) cfgs[ncfgs] + sizeof(struct pair);
|
||||
strcpy(cfgs[ncfgs]->name, de->d_name);
|
||||
cfgs[ncfgs]->value = (char*)cfgs[ncfgs]+sizeof(struct pair) + strlen(cfgs[ncfgs]->name)+1;
|
||||
cfgs[ncfgs]->value =
|
||||
(char *) cfgs[ncfgs] + sizeof(struct pair) + strlen(cfgs[ncfgs]->name) +
|
||||
1;
|
||||
sprintf(cfgs[ncfgs]->value, "%s/%s", dirs[di], de->d_name);
|
||||
ncfgs++;
|
||||
|
||||
@ -576,10 +594,8 @@ static int PreloadSystem(void) {
|
||||
return Preload(DEFAULT_PRELOAD);
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* Main...
|
||||
*
|
||||
*/
|
||||
int main(int argc, char *argv[])
|
||||
{
|
||||
@ -620,9 +636,8 @@ int main(int argc, char *argv[])
|
||||
IgnoreError = false;
|
||||
Quiet = false;
|
||||
|
||||
if (argc < 2) {
|
||||
if (argc < 2)
|
||||
Usage(stderr);
|
||||
}
|
||||
|
||||
while ((c =
|
||||
getopt_long(argc, argv, "bneNwfp::qoxaAXr:Vdh", longopts,
|
||||
@ -637,8 +652,9 @@ int main(int argc, char *argv[])
|
||||
break;
|
||||
case 'e':
|
||||
/*
|
||||
* For FreeBSD, -e means a "%s=%s\n" format. ("%s: %s\n" default)
|
||||
* We (and NetBSD) use "%s = %s\n" always, and -e to ignore errors.
|
||||
* For FreeBSD, -e means a "%s=%s\n" format.
|
||||
* ("%s: %s\n" default). We (and NetBSD) use
|
||||
* "%s = %s\n" always, and -e to ignore errors.
|
||||
*/
|
||||
IgnoreError = true;
|
||||
break;
|
||||
@ -675,7 +691,7 @@ int main(int argc, char *argv[])
|
||||
break;
|
||||
case 'V':
|
||||
printf(PROCPS_NG_VERSION);
|
||||
exit(0);
|
||||
return EXIT_SUCCESS;
|
||||
case 'd': /* BSD: print description ("vm.kvm_size: Size of KVM") */
|
||||
case 'h': /* BSD: human-readable (did FreeBSD 5 make -e default?) */
|
||||
case '?':
|
||||
@ -707,5 +723,3 @@ int main(int argc, char *argv[])
|
||||
|
||||
return ReturnCode;
|
||||
}
|
||||
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user