tests: Dont compare floats with ==
Comparing floats with == is bad and I should feel bad I did this. The problem is if something is close to, but not quite the exact same fails tests. I have used an epsilon of 1 because we don't care about accuracy, just that the function works well enough. References: issue procps-ng/procps#271 https://how-to.fandom.com/wiki/Howto_compare_floating_point_numbers_in_the_C_programming_language Signed-off-by: Craig Small <csmall@dropbear.xyz>
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
#include <math.h>
|
||||
#include "strutils.h"
|
||||
|
||||
struct strtod_tests {
|
||||
@@ -25,6 +26,11 @@ struct strtod_tests tests[] = {
|
||||
{NULL, 0.0}
|
||||
};
|
||||
|
||||
#define EPSILON 1.0 // Really not trying for precision here
|
||||
int dequal(const double d1, const double d2)
|
||||
{
|
||||
return fabs(d1-d2) < EPSILON;
|
||||
}
|
||||
|
||||
|
||||
int main(int argc, char *argv[])
|
||||
|
||||
Reference in New Issue
Block a user