emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

pwdx: re-create invalid process id check

Browse Source 
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This commit is contained in:
Sami Kerola 2011-12-26 18:42:05 +01:00
parent ab25578bee
commit 9d47cb0c38
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pwdx.c
View File

@ -35,6 +35,23 @@ static void __attribute__ ((__noreturn__)) usage(FILE * out)
exit(out == stderr ? EXIT_FAILURE : EXIT_SUCCESS); exit(out == stderr ? EXIT_FAILURE : EXIT_SUCCESS);
} }
int check_pid_argument(char *input)
{
int skip = 0;
long pid;
char *end = NULL;
if (!strncmp("/proc/", input, 6))
skip = 6;
pid = strtol(input + skip, &end, 10);
if (errno || input + skip == end || (end && *end))
return 1;
if (pid < 1)
return 1;
return 0;
}
int main(int argc, char *argv[]) int main(int argc, char *argv[])
{ {
char ch; char ch;
@ -78,6 +95,9 @@ int main(int argc, char *argv[])
/* Constant 10 is the length of strings "/proc/" + "/cwd" + 1 */ /* Constant 10 is the length of strings "/proc/" + "/cwd" + 1 */
char buf[10 + strlen(argv[i]) + 1]; char buf[10 + strlen(argv[i]) + 1];
if (check_pid_argument(argv[i]))
errx(EXIT_FAILURE, _("invalid process id: %s"),
argv[i]);
/* /*
* At this point, all arguments are in the form * At this point, all arguments are in the form
* /proc/NNNN or NNNN, so a simple check based on * /proc/NNNN or NNNN, so a simple check based on