emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: eliminate that potential vulnerability for TOCTOU

Browse Source 
Initially, I was going to ignore that coverity warning
CID #177876. But, since top may be running SETUID it's
best if it can be avoided instead. The fix was simple.

We'll trade the access() call for a real fopen() call.
This time-of-check-time-of-use warning should go away.
------------------------------------------------------

When XDG support was originally introduced in top, the
author made a poor choice in access(). A real question
that needed asking was 'does the file exist'. However,
the question that was asked was 'can this real user ID
or this real group ID access the file'. Then, when the
fopen() is finally issued, top would use the effective
user ID or the effective group ID to access that file.

That's what opened the potential TOCTOU vulnerability,
which was important only if top was running SUID/SGID.

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2017-10-07 00:00:00 -05:00 committed by Craig Small
parent d734d18f62
commit a02a31f7e9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
top/top.c
View File

@ -3188,7 +3188,7 @@ static void configs_read (void) {
p_home = "."; p_home = ".";
snprintf(Rc_name, sizeof(Rc_name), "%s/.%src", p_home, Myname); snprintf(Rc_name, sizeof(Rc_name), "%s/.%src", p_home, Myname);
if (access(Rc_name, F_OK)) { if (!(fp = fopen(Rc_name, "r"))) {
p = getenv("XDG_CONFIG_HOME"); p = getenv("XDG_CONFIG_HOME");
// ensure the path we get is absolute, fallback otherwise. // ensure the path we get is absolute, fallback otherwise.
if (!p || p[0] != '/') { if (!p || p[0] != '/') {
@ -3198,9 +3198,9 @@ static void configs_read (void) {
snprintf(Rc_name, sizeof(Rc_name), "%s/procps", p); snprintf(Rc_name, sizeof(Rc_name), "%s/procps", p);
(void)mkdir(Rc_name, 0700); (void)mkdir(Rc_name, 0700);
snprintf(Rc_name, sizeof(Rc_name), "%s/procps/%src", p, Myname); snprintf(Rc_name, sizeof(Rc_name), "%s/procps/%src", p, Myname);
fp = fopen(Rc_name, "r");
} }
fp = fopen(Rc_name, "r");
if (fp) { if (fp) {
int tmp_whole, tmp_fract; int tmp_whole, tmp_fract;
if (fgets(fbuf, sizeof(fbuf), fp)) // ignore eyecatcher if (fgets(fbuf, sizeof(fbuf), fp)) // ignore eyecatcher