emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: Prevent integer overflow in adj_geometry().

Browse Source
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent 23baeb1175
commit b4d068e624
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
top/top.c
View File

@ -2015,8 +2015,10 @@ static void adj_geometry (void) {
Screen_rows = w_rows ? w_rows : INT_MAX; Screen_rows = w_rows ? w_rows : INT_MAX;
Pseudo_size = (sizeof(*Pseudo_screen) * ROWMAXSIZ); Pseudo_size = (sizeof(*Pseudo_screen) * ROWMAXSIZ);
} else { } else {
const int max_rows = INT_MAX / (sizeof(*Pseudo_screen) * ROWMAXSIZ);
if (w_cols && w_cols < Screen_cols) Screen_cols = w_cols; if (w_cols && w_cols < Screen_cols) Screen_cols = w_cols;
if (w_rows && w_rows < Screen_rows) Screen_rows = w_rows; if (w_rows && w_rows < Screen_rows) Screen_rows = w_rows;
if (Screen_rows < 0 || Screen_rows > max_rows) Screen_rows = max_rows;
Pseudo_size = (sizeof(*Pseudo_screen) * ROWMAXSIZ) * Screen_rows; Pseudo_size = (sizeof(*Pseudo_screen) * ROWMAXSIZ) * Screen_rows;
} }
// we'll only grow our Pseudo_screen, never shrink it // we'll only grow our Pseudo_screen, never shrink it