emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

0086-pmap: Prevent integer overflow in main().

Browse Source 
Unlikely to ever happen, but just in case.

Signed-off-by: Craig Small <csmall@enc.com.au>
This commit is contained in:
Qualys Security Advisory 1970-01-01 00:00:00 +00:00 committed by Craig Small
parent 105ab093b8
commit bf409f92fd
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pmap.c
View File

@ -30,6 +30,7 @@
#include <sys/types.h> #include <sys/types.h>
#include <unistd.h> #include <unistd.h>
#include <assert.h> #include <assert.h>
#include <limits.h>
#include "c.h" #include "c.h"
#include "fileutils.h" #include "fileutils.h"
@ -1136,6 +1137,8 @@ int main(int argc, char **argv)
} }
} }
} }
if ((size_t)argc >= INT_MAX / sizeof(pid_t))
xerrx(EXIT_FAILURE, _("too many arguments"));
if (procps_pids_new(&Pids_info, Pid_items, 4)) if (procps_pids_new(&Pids_info, Pid_items, 4))
xerrx(EXIT_FAILURE, _("library failed pids statistics")); xerrx(EXIT_FAILURE, _("library failed pids statistics"));
pidlist = xmalloc(sizeof(pid_t) * argc); pidlist = xmalloc(sizeof(pid_t) * argc);