emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

library: oldproc_open has always yes check

Browse Source 
if (info->flags | PROC_UID)
Something OR a non-zero constant is always true.
Looks like it should be and'ed for the standard flag masking
pattern.

References:
  Coverity #99118

Signed-off-by: Craig Small <csmall@dropbear.xyz>
This commit is contained in:
Craig Small 2016-05-14 22:55:16 +10:00
parent f85d9a2b95
commit bfb7361980
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proc/pids.c
View File

@ -977,7 +977,7 @@ static inline int oldproc_open (
if (info->PT == NULL) { if (info->PT == NULL) {
va_start(vl, supp_flgs); va_start(vl, supp_flgs);
ids = va_arg(vl, int*); ids = va_arg(vl, int*);
if (info->flags | PROC_UID) num = va_arg(vl, int); if (info->flags & PROC_UID) num = va_arg(vl, int);
va_end(vl); va_end(vl);
if (NULL == (info->PT = openproc(info->flags | supp_flgs, ids, num))) if (NULL == (info->PT = openproc(info->flags | supp_flgs, ids, num)))
return 0; return 0;