emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

pgrep: Remove >15 warning

Browse Source 
As comm length can be longer than 15 characters with newer kernels, it
doesn't make sense to have a warning when you make the match string
longer than this.

As a side-effect, it removes the false-positive you got when you used
long regex matches (see issue #92 )

References:
 commit 2cfdbbe897
 procps-ng/procps#92
This commit is contained in:
Craig Small 2018-05-19 08:14:06 +10:00
parent 52dc8dcdea
commit c32ab58b94
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -4,6 +4,7 @@ procps-ng-3.3.15
No removals, no new functions No removals, no new functions
Changes: slab and pid structures Changes: slab and pid structures
* pgrep: Fix stack-based buffer overflow CVE-2018-1125 * pgrep: Fix stack-based buffer overflow CVE-2018-1125
* pgrep: Remove >15 warning as comm can be longer issue #92
* ps: Fix buffer overflow in output buffer, causing DOS CVE-2018-1123 * ps: Fix buffer overflow in output buffer, causing DOS CVE-2018-1123
* library: Just check for SIGLOST and don't delete it issue #93 * library: Just check for SIGLOST and don't delete it issue #93
* library: Fix integer overflow and LPE in file2strvec CVE-2018-1124 * library: Fix integer overflow and LPE in file2strvec CVE-2018-1124

4
pgrep.c
View File

@ -653,10 +653,6 @@ static struct el * select_procs (int *num)
closeproc (ptp); closeproc (ptp);
*num = matches; *num = matches;
if ((!matches) && (!opt_full) && opt_pattern && (strlen(opt_pattern) > 15))
xwarnx(_("pattern that searches for process name longer than 15 characters will result in zero matches\n"
"Try `%s -f' option to match against the complete command line."),
program_invocation_short_name);
return list; return list;
} }