emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

top: fix regression created when fields mgmt reorg'd

Browse Source 
When the calibrate_fields function was broken up for
mainainability, an obscure regression was introduced.

For the resulting bug to affect the display, all of
the following conditions would have to be met:
 . USE_X_COLHDR was not defined
 . column highlighting had been turned on
 . many, perhaps all, fields were displayable
 . the user then typed the <End> key
 . and the current sort column just happened to
   be immediately to the left of the left-most
   visible field

This patch corrects for that remote possibility.

Reference:
commit d0e16acf156b066d56415b1b7ccbfad4ae1526d8

Signed-off-by: Jim Warner <james.warner@comcast.net>
This commit is contained in:
Jim Warner 2012-02-10 10:10:10 -06:00 committed by Craig Small
parent 22a56e6bfd
commit ccb5144050
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
top/top.c
View File

@ -1538,6 +1538,9 @@ static void calibrate_fields (void) {
s = scat(s, h); s = scat(s, h);
w->endpflg = i; w->endpflg = i;
} }
#ifndef USE_X_COLHDR
if (X_XOF == w->pflgsall[w->endpflg]) ++w->endpflg;
#endif
} // end: if (VIZISw(w)) } // end: if (VIZISw(w))
if (Rc.mode_altscr) w = w->next; if (Rc.mode_altscr) w = w->next;