e40b0060c2
Before this commit, the test checking `vmstat -m` (slabinfo) output uses
a fairly strict regular expression that only allows alphanumeric
characters and a few exceptions such as "_", "-", "(" and ")".
However, recent kernels use a wider range of characters, such as ">".
For instance, see this Linux commit which creates a "page->ptl" slab:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/mm/memory.c?id=b35f1819acd9243a3ff7ad25b1fa8bd6bfe80fb2#n4283
Other patches for reporting slab usage per memcg include the names of
the cgroup in the slabinfo output, which can include additional
characters and use dots for abbreviation.
The check should not be so string, instead it could simply look for a
chain of non-whitespace characters and that should be enough.
Tested that `make check` is still working, including in some of the
environments where features that enable the additional slabinfo names.
Signed-off-by: Filipe Brandenburger <filbranden@google.com>
Signed-off-by: Craig Small <csmall@enc.com.au>
|
||
|---|---|---|
| .. | ||
| config | ||
| free.test | ||
| kill.test | ||
| lib.test | ||
| pgrep.test | ||
| pkill.test | ||
| pmap.test | ||
| ps.test | ||
| pwdx.test | ||
| slabtop.test | ||
| sysctl.test | ||
| uptime.test | ||
| vmstat.test | ||
| w.test | ||
| .gitignore | ||
| Makefile.am | ||
| README | ||
How to use check suite ---------------------- You need DejaGNU package. Assuming you have it all you need to do is make check Something failed now what ------------------------- First determine what did not work. If only one check failed you can run it individually in debugging mode. For example runtest -a -de -v w.test/w.exp Expect binary is /usr/bin/expect Using /usr/share/dejagnu/runtest.exp as main test driver [...] Do not bother capturing screen output, it is in testrun.log which test suite generated. $ ls testrun.* dbg.log dbg.log testrun.log testrun.sum The reason why test failed should be in dbg.log. Assuming you figured out the reason you could write a patch fixing w.test/w.exp and send it to upstream. If you do not know how, or have time, to fix the issue create tar.gz file containing test run logs and submit it to upstream maintainers. Notice that in later case upstream sometimes has to ask clarifying questions about environment where problem occurred.