procps/ps
Qualys Security Advisory 0bd44bc76e 0059-ps/output.c: Enforce a safe range for max_rightward.
Enforce a maximum max_rightward of OUTBUF_SIZE-1, because it is used in
constructs such as "snprintf(outbuf, max_rightward+1," (we could remove
the extra check at the beginning of forest_helper() now, but we decided
to leave it, as a precaution and reminder).

The minimum max_rightward check is not strictly needed, because it is
unsigned. However, we decided to add it anyway:

- most of the other variables are signed;

- make it visually clear that this case is properly handled;

- ideally, the minimum max_rightward should be 1, not 0 (to prevent
  integer overflows such as "max_rightward-1"), but this might change
  the behavior/output of ps, so we decided against it, for now.

Instead, we fixed the only function that overflows if max_rightward is
0. Also, enforce the same safe range for max_leftward, although it is
never used throughout the code-base.

---------------------------- adapted for newlib branch
. adapted via 'patch' without rejections

Signed-off-by: Jim Warner <james.warner@comcast.net>
2018-06-09 21:45:38 +10:00
..
common.h ps: changed to exploit a newly added UID used at login 2018-02-19 20:33:59 +11:00
COPYING license: update FSF addresses 2012-03-04 08:04:24 +11:00
display.c 0055-ps/display.c: Harden show_tree(). 2018-06-09 21:45:38 +10:00
global.c ps: changed to exploit a newly added UID used at login 2018-02-19 20:33:59 +11:00
HACKING docs: remove old information from HACKING 2012-01-13 22:42:38 +01:00
help.c library: cleanup of library includes 2016-04-16 17:03:57 +10:00
output.c 0059-ps/output.c: Enforce a safe range for max_rightward. 2018-06-09 21:45:38 +10:00
parser.c misc: eliminate all those remaining gcc -Wall warnings 2017-05-22 21:38:10 +10:00
ps.1 ps: add times & cputimes format specifiers: cumulative CPU time in seconds 2018-03-02 22:19:40 +11:00
regression procps 010114 2002-02-01 22:47:29 +00:00
select.c ps: exploit those new <pids> task/threads capabilities 2015-10-05 21:52:08 +11:00
sortformat.c related: change for lost 'PROCPS_' enumerator prefixes 2016-07-26 20:49:44 +10:00
stacktrace.c misc: just eliminate several 'unused' warning messages 2016-07-26 07:59:48 +10:00