subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
#include <sys/types.h>
|
|
|
|
#include <pwd.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include <subid.h>
|
|
|
|
#include <string.h>
|
|
|
|
|
|
|
|
enum subid_status shadow_subid_has_any_range(const char *owner, enum subid_type t, bool *result)
|
|
|
|
{
|
|
|
|
if (strcmp(owner, "ubuntu") == 0) {
|
|
|
|
*result = true;
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|
|
|
|
if (strcmp(owner, "error") == 0) {
|
|
|
|
*result = false;
|
|
|
|
return SUBID_STATUS_ERROR;
|
|
|
|
}
|
|
|
|
if (strcmp(owner, "unknown") == 0) {
|
|
|
|
*result = false;
|
|
|
|
return SUBID_STATUS_UNKNOWN_USER;
|
|
|
|
}
|
|
|
|
if (strcmp(owner, "conn") == 0) {
|
|
|
|
*result = false;
|
|
|
|
return SUBID_STATUS_ERROR_CONN;
|
|
|
|
}
|
|
|
|
if (t == ID_TYPE_UID) {
|
|
|
|
*result = strcmp(owner, "user1") == 0;
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|
|
|
|
|
|
|
|
*result = strcmp(owner, "group1") == 0;
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|
|
|
|
|
|
|
|
enum subid_status shadow_subid_has_range(const char *owner, unsigned long start, unsigned long count, enum subid_type t, bool *result)
|
|
|
|
{
|
|
|
|
if (strcmp(owner, "ubuntu") == 0 &&
|
|
|
|
start >= 200000 &&
|
|
|
|
count <= 100000) {
|
|
|
|
*result = true;
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|
|
|
|
*result = false;
|
|
|
|
if (strcmp(owner, "error") == 0)
|
|
|
|
return SUBID_STATUS_ERROR;
|
|
|
|
if (strcmp(owner, "unknown") == 0)
|
|
|
|
return SUBID_STATUS_UNKNOWN_USER;
|
|
|
|
if (strcmp(owner, "conn") == 0)
|
|
|
|
return SUBID_STATUS_ERROR_CONN;
|
|
|
|
|
|
|
|
if (t == ID_TYPE_UID && strcmp(owner, "user1") != 0)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
if (t == ID_TYPE_GID && strcmp(owner, "group1") != 0)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
|
|
|
|
if (start < 100000)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
if (count >= 65536)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
*result = true;
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|
|
|
|
|
|
|
|
// So if 'user1' or 'ubuntu' is defined in passwd, we'll return those values,
|
|
|
|
// to ease manual testing. For automated testing, if you return those values,
|
|
|
|
// we'll return 1000 for ubuntu and 1001 otherwise.
|
|
|
|
static uid_t getnamuid(const char *name) {
|
|
|
|
struct passwd *pw;
|
|
|
|
|
|
|
|
pw = getpwnam(name);
|
|
|
|
if (pw)
|
|
|
|
return pw->pw_uid;
|
|
|
|
|
|
|
|
// For testing purposes
|
|
|
|
return strcmp(name, "ubuntu") == 0 ? (uid_t)1000 : (uid_t)1001;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int alloc_uid(uid_t **uids, uid_t id) {
|
|
|
|
*uids = malloc(sizeof(uid_t));
|
|
|
|
if (!*uids)
|
|
|
|
return -1;
|
|
|
|
*uids[0] = id;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
enum subid_status shadow_subid_find_subid_owners(unsigned long id, enum subid_type id_type, uid_t **uids, int *count)
|
|
|
|
{
|
|
|
|
if (id >= 100000 && id < 165536) {
|
|
|
|
*count = alloc_uid(uids, getnamuid("user1"));
|
|
|
|
if (*count == 1)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
return SUBID_STATUS_ERROR; // out of memory
|
|
|
|
}
|
|
|
|
if (id >= 200000 && id < 300000) {
|
|
|
|
*count = alloc_uid(uids, getnamuid("ubuntu"));
|
|
|
|
if (*count == 1)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
return SUBID_STATUS_ERROR; // out of memory
|
|
|
|
}
|
|
|
|
*count = 0; // nothing found
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|
|
|
|
|
2021-05-22 22:46:50 +05:30
|
|
|
enum subid_status shadow_subid_list_owner_ranges(const char *owner, enum subid_type id_type, struct subid_range **in_ranges, int *count)
|
subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
{
|
2021-05-22 22:46:50 +05:30
|
|
|
struct subid_range *ranges;
|
subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
|
|
|
|
*count = 0;
|
|
|
|
if (strcmp(owner, "error") == 0)
|
|
|
|
return SUBID_STATUS_ERROR;
|
|
|
|
if (strcmp(owner, "unknown") == 0)
|
|
|
|
return SUBID_STATUS_UNKNOWN_USER;
|
|
|
|
if (strcmp(owner, "conn") == 0)
|
|
|
|
return SUBID_STATUS_ERROR_CONN;
|
|
|
|
|
2021-05-22 22:46:50 +05:30
|
|
|
*in_ranges = NULL;
|
subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
if (strcmp(owner, "user1") != 0 && strcmp(owner, "ubuntu") != 0 &&
|
|
|
|
strcmp(owner, "group1") != 0)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
if (id_type == ID_TYPE_GID && strcmp(owner, "user1") == 0)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
if (id_type == ID_TYPE_UID && strcmp(owner, "group1") == 0)
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
2021-05-22 22:46:50 +05:30
|
|
|
ranges = (struct subid_range *)malloc(sizeof(struct subid_range));
|
subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
if (!*ranges)
|
|
|
|
return SUBID_STATUS_ERROR;
|
|
|
|
if (strcmp(owner, "user1") == 0 || strcmp(owner, "group1") == 0) {
|
2021-05-22 22:46:50 +05:30
|
|
|
ranges[0].start = 100000;
|
|
|
|
ranges[0].count = 65536;
|
subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
} else {
|
2021-05-22 22:46:50 +05:30
|
|
|
ranges[0].start = 200000;
|
|
|
|
ranges[0].count = 100000;
|
subids: support nsswitch
Closes #154
When starting any operation to do with subuid delegation, check
nsswitch for a module to use. If none is specified, then use
the traditional /etc/subuid and /etc/subgid files.
Currently only one module is supported, and there is no fallback
to the files on errors. Several possibilities could be considered:
1. in case of connection error, fall back to files
2. in case of unknown user, also fall back to files
etc...
When non-files nss module is used, functions to edit the range
are not supported. It may make sense to support it, but it also
may make sense to require another tool to be used.
libsubordinateio also uses the nss_ helpers. This is how for instance
lxc could easily be converted to supporting nsswitch.
Add a set of test cases, including a dummy libsubid_zzz module. This
hardcodes values such that:
'ubuntu' gets 200000 - 300000
'user1' gets 100000 - 165536
'error' emulates an nss module error
'unknown' emulates a user unknown to the nss module
'conn' emulates a connection error ot the nss module
Changes to libsubid:
Change the list_owner_ranges api: return a count instead of making the array
null terminated.
This is a breaking change, so bump the libsubid abi major number.
Rename free_subuid_range and free_subgid_range to ungrant_subuid_range,
because otherwise it's confusing with free_subid_ranges which frees
memory.
Run libsubid tests in jenkins
Switch argument order in find_subid_owners
Move the db locking into subordinateio.c
Signed-off-by: Serge Hallyn <serge@hallyn.com>
2021-02-01 05:08:20 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
*count = 1;
|
|
|
|
*in_ranges = ranges;
|
|
|
|
|
|
|
|
return SUBID_STATUS_SUCCESS;
|
|
|
|
}
|