emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* src/login.c: Ignore the return value of puts(), fputs(),

Browse Source 
strftime().
This commit is contained in:
nekral-guest 2009-04-22 20:17:11 +00:00
parent 46d697cded
commit 349efcb0a6
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2009-04-22 Nicolas François <nicolas.francois@centraliens.net>
* src/login.c: Ignore the return value of puts(), fputs(),
strftime().
2009-04-22 Nicolas François <nicolas.francois@centraliens.net> 2009-04-22 Nicolas François <nicolas.francois@centraliens.net>
* src/login.c: timeout, delay, and retries should be unsigned. * src/login.c: timeout, delay, and retries should be unsigned.

14
src/login.c
View File

@ -269,7 +269,7 @@ static void check_nologin (bool login_to_root)
closelog (); closelog ();
exit (0); exit (0);
} }
puts (_("\n[Disconnect bypassed -- root login allowed.]")); (void) puts (_("\n[Disconnect bypassed -- root login allowed.]"));
} }
} }
#endif /* !USE_PAM */ #endif /* !USE_PAM */
@ -794,7 +794,7 @@ int main (int argc, char **argv)
exit(0); exit(0);
} else if (retcode == PAM_ABORT) { } else if (retcode == PAM_ABORT) {
/* Serious problems, quit now */ /* Serious problems, quit now */
fputs (_("login: abort requested by PAM\n"),stderr); (void) fputs (_("login: abort requested by PAM\n"), stderr);
SYSLOG ((LOG_ERR,"PAM_ABORT returned from pam_authenticate()")); SYSLOG ((LOG_ERR,"PAM_ABORT returned from pam_authenticate()"));
PAM_END; PAM_END;
exit(99); exit(99);
@ -1068,7 +1068,7 @@ int main (int argc, char **argv)
(void) sleep (delay); (void) sleep (delay);
} }
puts (_("Login incorrect")); (void) puts (_("Login incorrect"));
/* allow only one attempt with -r or -f */ /* allow only one attempt with -r or -f */
if (rflg || fflg || (retries <= 0)) { if (rflg || fflg || (retries <= 0)) {
@ -1256,7 +1256,7 @@ int main (int argc, char **argv)
/* Reset the lockout times if logged in */ /* Reset the lockout times if logged in */
if ( (0 != faillog.fail_max) if ( (0 != faillog.fail_max)
&& (faillog.fail_cnt >= faillog.fail_max)) { && (faillog.fail_cnt >= faillog.fail_max)) {
puts (_("Warning: login re-enabled after temporary lockout.")); (void) puts (_("Warning: login re-enabled after temporary lockout."));
SYSLOG ((LOG_WARN, SYSLOG ((LOG_WARN,
"login '%s' re-enabled after temporary lockout (%d failures)", "login '%s' re-enabled after temporary lockout (%d failures)",
username, (int) faillog.fail_cnt)); username, (int) faillog.fail_cnt));
@ -1267,9 +1267,9 @@ int main (int argc, char **argv)
time_t ll_time = ll.ll_time; time_t ll_time = ll.ll_time;
#ifdef HAVE_STRFTIME #ifdef HAVE_STRFTIME
strftime (ptime, sizeof (ptime), (void) strftime (ptime, sizeof (ptime),
"%a %b %e %H:%M:%S %z %Y", "%a %b %e %H:%M:%S %z %Y",
localtime (&ll_time)); localtime (&ll_time));
printf (_("Last login: %s on %s"), printf (_("Last login: %s on %s"),
ptime, ll.ll_line); ptime, ll.ll_line);
#else #else