* libmisc/pwdcheck.c (passwd_check): The progname is not used.

* libmisc/pwdcheck.c: Ignore the return value of sleep().
	* libmisc/pwdcheck.c: Use exit(EXIT_FAILURE) instead of exit(1).
This commit is contained in:
nekral-guest 2009-04-23 20:17:02 +00:00
parent c357e94283
commit 3d2f164dca
2 changed files with 10 additions and 4 deletions

View File

@ -1,3 +1,9 @@
2009-04-22 Nicolas François <nicolas.francois@centraliens.net>
* libmisc/pwdcheck.c (passwd_check): The progname is not used.
* libmisc/pwdcheck.c: Ignore the return value of sleep().
* libmisc/pwdcheck.c: Use exit(EXIT_FAILURE) instead of exit(1).
2009-04-22 Nicolas François <nicolas.francois@centraliens.net> 2009-04-22 Nicolas François <nicolas.francois@centraliens.net>
* libmisc/setupenv.c: Avoid assignments in comparisons. * libmisc/setupenv.c: Avoid assignments in comparisons.
@ -5,7 +11,7 @@
* libmisc/setupenv.c: Ignore the return value of fclose (file * libmisc/setupenv.c: Ignore the return value of fclose (file
opened read-only) opened read-only)
* libmisc/setupenv.c: Ignore the return value of puts(). * libmisc/setupenv.c: Ignore the return value of puts().
* libmisc/setupenv.c:Avoid implicit conversion of pointers to * libmisc/setupenv.c: Avoid implicit conversion of pointers to
booleans. booleans.
2009-04-22 Nicolas François <nicolas.francois@centraliens.net> 2009-04-22 Nicolas François <nicolas.francois@centraliens.net>

View File

@ -40,7 +40,7 @@
#include "defines.h" #include "defines.h"
#include "pwauth.h" #include "pwauth.h"
void passwd_check (const char *user, const char *passwd, const char *progname) void passwd_check (const char *user, const char *passwd, unused const char *progname)
{ {
struct spwd *sp; struct spwd *sp;
@ -50,9 +50,9 @@ void passwd_check (const char *user, const char *passwd, const char *progname)
} }
if (pw_auth (passwd, user, PW_LOGIN, (char *) 0) != 0) { if (pw_auth (passwd, user, PW_LOGIN, (char *) 0) != 0) {
SYSLOG ((LOG_WARN, "incorrect password for `%s'", user)); SYSLOG ((LOG_WARN, "incorrect password for `%s'", user));
sleep (1); (void) sleep (1);
fprintf (stderr, _("Incorrect password for %s.\n"), user); fprintf (stderr, _("Incorrect password for %s.\n"), user);
exit (1); exit (EXIT_FAILURE);
} }
} }
#else /* USE_PAM */ #else /* USE_PAM */