emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

useradd: free grp to avoid leak

Browse Source 
covscan issue:
Error: RESOURCE_LEAK (CWE-772): [#def39] [important]
src/useradd.c:728: alloc_fn: Storage is returned from allocation function "get_local_group".
src/useradd.c:728: var_assign: Assigning: "grp" = storage returned from "get_local_group(list)".
src/useradd.c:728: overwrite_var: Overwriting "grp" in "grp = get_local_group(list)" leaks the storage that "grp" points to.
726|   		 * GID values, otherwise the string is looked up as is.
727|   		 */
728|-> 		grp = get_local_group (list);
729|
730|   		/*
This commit is contained in:
ikerexxe 2020-10-27 11:35:53 +01:00
parent 2df8c0728d
commit 569bd1d54f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/useradd.c
View File

@ -729,7 +729,7 @@ static int set_defaults (void)
static int get_groups (char *list) static int get_groups (char *list)
{ {
char *cp; char *cp;
const struct group *grp; struct group *grp;
int errors = 0; int errors = 0;
int ngroups = 0; int ngroups = 0;
@ -808,6 +808,7 @@ static int get_groups (char *list)
* Add the group name to the user's list of groups. * Add the group name to the user's list of groups.
*/ */
user_groups[ngroups++] = xstrdup (grp->gr_name); user_groups[ngroups++] = xstrdup (grp->gr_name);
free (grp);
} while (NULL != list); } while (NULL != list);
close_group_files (); close_group_files ();