emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Merge pull request #8 from shadow-maint/newgrpleak

Browse Source 
Fix a resource leak in syslog_sg
This commit is contained in:
Serge Hallyn 2015-11-12 23:02:13 -06:00
commit 5fadb341c3
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/newgrp.c
View File

@ -255,12 +255,15 @@ static void syslog_sg (const char *name, const char *group)
{ {
const char *loginname = getlogin (); const char *loginname = getlogin ();
const char *tty = ttyname (0); const char *tty = ttyname (0);
char *free_login = NULL, *free_tty = NULL;
if (loginname != NULL) { if (loginname != NULL) {
loginname = xstrdup (loginname); free_login = xstrdup (loginname);
loginname = free_login;
} }
if (tty != NULL) { if (tty != NULL) {
tty = xstrdup (tty); free_tty = xstrdup (tty);
tty = free_tty;
} }
if (loginname == NULL) { if (loginname == NULL) {
@ -372,6 +375,8 @@ static void syslog_sg (const char *name, const char *group)
(void) signal (SIGTTOU, SIG_DFL); (void) signal (SIGTTOU, SIG_DFL);
} }
#endif /* USE_PAM */ #endif /* USE_PAM */
free(free_login);
free(free_tty);
} }
#endif /* USE_SYSLOG */ #endif /* USE_SYSLOG */