emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* src/su.c: Too much const were added on 2011-08-15. pw in

Browse Source 
save_caller_context() is allocated and freed.
	* src/su.c: Added missing #endif indication
	* src/su.c save_caller_context(): password only needed if
	SU_ACCESS and !USE_PAM.
This commit is contained in:
nekral-guest
2011-09-18 17:47:03 +00:00
parent 603d949ed5
commit 6f05b866bc
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ChangeLog
View File

@ -1,3 +1,11 @@
2011-09-18 Nicolas François <nicolas.francois@centraliens.net>
* src/su.c: Too much const were added on 2011-08-15. pw in
save_caller_context() is allocated and freed.
* src/su.c: Added missing #endif indication
* src/su.c save_caller_context(): password only needed if
SU_ACCESS and !USE_PAM.
2011-09-18 Nicolas François <nicolas.francois@centraliens.net> 2011-09-18 Nicolas François <nicolas.francois@centraliens.net>
* src/usermod.c: date_to_str() is always called with negativ set * src/usermod.c: date_to_str() is always called with negativ set
@ -81,7 +89,7 @@
* src/su.c: Add splint annotations. * src/su.c: Add splint annotations.
* src/su.c: Set caller_on_console as boolean. * src/su.c: Set caller_on_console as boolean.
* src/su.c: Ignore retunr value from fputs (usage) / puts (prompt). * src/su.c: Ignore return value from fputs (usage) / puts (prompt).
* src/su.c: Improved memory management. * src/su.c: Improved memory management.
2011-08-14 Nicolas François <nicolas.francois@centraliens.net> 2011-08-14 Nicolas François <nicolas.francois@centraliens.net>

8
src/su.c
View File

@ -654,8 +654,12 @@ static /*@only@*/struct passwd * check_perms (void)
*/ */
static void save_caller_context (char **argv) static void save_caller_context (char **argv)
{ {
const struct passwd *pw = NULL; struct passwd *pw = NULL;
#ifndef USE_PAM
#ifdef SU_ACCESS
const char *password = NULL; const char *password = NULL;
#endif /* SU_ACCESS */
#endif /* !USE_PAM */
/* /*
* Get the program name. The program name is used as a prefix to * Get the program name. The program name is used as a prefix to
* most error messages. * most error messages.
@ -673,7 +677,7 @@ static void save_caller_context (char **argv)
if ((isatty (0) != 0) && (NULL != caller_tty)) { if ((isatty (0) != 0) && (NULL != caller_tty)) {
#ifndef USE_PAM #ifndef USE_PAM
caller_on_console = console (caller_tty); caller_on_console = console (caller_tty);
#endif #endif /* !USE_PAM */
} else { } else {
/* /*
* Be more paranoid, like su from SimplePAMApps. --marekm * Be more paranoid, like su from SimplePAMApps. --marekm