emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

chsh: Verify that login shell path is absolute

Browse Source 
The getusershell implementation of musl returns every line within the
/etc/shells file, which even includes comments. Only consider absolute
paths for login shells.

Signed-off-by: Samanta Navarro <ferivoz@riseup.net>
This commit is contained in:
Samanta Navarro 2023-05-18 11:58:19 +00:00 committed by Iker Pedrosa
parent 812f934e77
commit 7321ceaf69
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/chsh.c
View File

@ -574,7 +574,8 @@ int main (int argc, char **argv)
fail_exit (1); fail_exit (1);
} }
if ( !amroot if ( !amroot
&& ( is_restricted_shell (loginsh) && ( loginsh[0] != '/'
|| is_restricted_shell (loginsh)
|| (access (loginsh, X_OK) != 0))) { || (access (loginsh, X_OK) != 0))) {
fprintf (stderr, _("%s: %s is an invalid shell\n"), Prog, loginsh); fprintf (stderr, _("%s: %s is an invalid shell\n"), Prog, loginsh);
fail_exit (1); fail_exit (1);