Do not drop const qualifier for Basename
The private Basename() implementation does not modify its argument, so a cast to a non-const char pointer is not necessary. newgrp.c:790:39: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] 790 | progbase = (char *) Basename ((char *) prog); | ^ newgrp.c:790:20: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] 790 | progbase = (char *) Basename ((char *) prog); | ^ shell.c:48:70: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] 48 | (void) snprintf (arg0, sizeof arg0, "-%s", Basename ((char *) file)); | ^
This commit is contained in:
@@ -379,7 +379,7 @@ int main (int argc, char **argv)
|
||||
int err = 0;
|
||||
gid_t gid;
|
||||
char *cp;
|
||||
char *progbase;
|
||||
const char *progbase;
|
||||
const char *name, *prog;
|
||||
char *group = NULL;
|
||||
char *command = NULL;
|
||||
@@ -787,7 +787,7 @@ int main (int argc, char **argv)
|
||||
* Now I try to find the basename of the login shell. This will
|
||||
* become argv[0] of the spawned command.
|
||||
*/
|
||||
progbase = (char *) Basename ((char *) prog);
|
||||
progbase = Basename (prog);
|
||||
|
||||
/*
|
||||
* Switch back to her home directory if i am doing login
|
||||
|
Reference in New Issue
Block a user