emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Merge pull request #268 from stoeckmann/chfn

Browse Source 
chfn: Prevent buffer overflow.
This commit is contained in:
Serge Hallyn 2020-08-10 13:45:15 -05:00 committed by GitHub
commit b215e9d02c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/chfn.c
View File

@ -61,7 +61,7 @@ static char fullnm[BUFSIZ];
static char roomno[BUFSIZ]; static char roomno[BUFSIZ];
static char workph[BUFSIZ]; static char workph[BUFSIZ];
static char homeph[BUFSIZ]; static char homeph[BUFSIZ];
static char slop[BUFSIZ]; static char slop[BUFSIZ + 1 + 80];
static bool amroot; static bool amroot;
/* Flags */ /* Flags */
static bool fflg = false; /* -f - set full name */ static bool fflg = false; /* -f - set full name */
@ -311,6 +311,11 @@ static void process_flags (int argc, char **argv)
exit (E_NOPERM); exit (E_NOPERM);
} }
oflg = true; oflg = true;
if (strlen (optarg) > (unsigned int) 80) {
fprintf (stderr,
_("%s: fields too long\n"), Prog);
exit (E_NOPERM);
}
STRFCPY (slop, optarg); STRFCPY (slop, optarg);
break; break;
case 'r': case 'r':