emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Free memory on error path

Browse Source 
When multiple entries with the same name are encountered, nentry is
not properly freed, which results in a memory leak.
This commit is contained in:
Tobias Stoeckmann
2015-07-12 14:30:32 +02:00
parent df5dafe049
commit c17f5ec460
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/commonio.c
View File

@@ -1081,6 +1081,7 @@ int commonio_update (struct commonio_db *db, const void *eptr)
if (NULL != p) { if (NULL != p) {
if (next_entry_by_name (db, p->next, db->ops->getname (eptr)) != NULL) { if (next_entry_by_name (db, p->next, db->ops->getname (eptr)) != NULL) {
fprintf (stderr, _("Multiple entries named '%s' in %s. Please fix this with pwck or grpck.\n"), db->ops->getname (eptr), db->filename); fprintf (stderr, _("Multiple entries named '%s' in %s. Please fix this with pwck or grpck.\n"), db->ops->getname (eptr), db->filename);
db->ops->free (nentry);
return 0; return 0;
} }
db->ops->free (p->eptr); db->ops->free (p->eptr);