emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

libmisc: don't free members variable

Browse Source 
In 9eb191edc4 I included a free() that
frees the members variable, which in turn causes the comma_to_list()
function to return an array of empty elements. The array variable holds
a list of pointers that point to offsets of the members variable. When
the function succeeds freeing members variable causes the elements of
the array variable to point to an empty string.

This is causing several regressions in our internal testing environment.
So, I'm reverting the change.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This commit is contained in:
Iker Pedrosa 2021-07-14 11:59:38 +02:00
parent 9eb191edc4
commit c3cf23b00c
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libmisc/list.c
View File

@ -263,8 +263,6 @@ bool is_on_list (char *const *list, const char *member)
} }
} }
free (members);
/* /*
* Return the new array of pointers * Return the new array of pointers
*/ */