emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

pwck.c: do not pass O_CREAT

Browse Source 
It causes a crash later when we try to close files.

Closes #96

Signed-off-by: Serge Hallyn <shallyn@cisco.com>
This commit is contained in:
Serge Hallyn 2018-03-24 20:29:48 -05:00
parent b63aca9a2c
commit d3790feac0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pwck.c
View File

@ -281,7 +281,7 @@ static void open_files (void)
* Open the files. Use O_RDONLY if we are in read_only mode, O_RDWR * Open the files. Use O_RDONLY if we are in read_only mode, O_RDWR
* otherwise. * otherwise.
*/ */
if (pw_open (read_only ? O_RDONLY : O_CREAT | O_RDWR) == 0) { if (pw_open (read_only ? O_RDONLY : O_RDWR) == 0) {
fprintf (stderr, _("%s: cannot open %s\n"), fprintf (stderr, _("%s: cannot open %s\n"),
Prog, pw_dbname ()); Prog, pw_dbname ());
if (use_system_pw_file) { if (use_system_pw_file) {
@ -290,7 +290,7 @@ static void open_files (void)
fail_exit (E_CANTOPEN); fail_exit (E_CANTOPEN);
} }
if (is_shadow && !use_tcb) { if (is_shadow && !use_tcb) {
if (spw_open (read_only ? O_RDONLY : O_CREAT | O_RDWR) == 0) { if (spw_open (read_only ? O_RDONLY : O_RDWR) == 0) {
fprintf (stderr, _("%s: cannot open %s\n"), fprintf (stderr, _("%s: cannot open %s\n"),
Prog, spw_dbname ()); Prog, spw_dbname ());
if (use_system_spw_file) { if (use_system_spw_file) {
@ -566,7 +566,7 @@ static void check_pw_file (int *errors, bool *changed)
continue; continue;
} }
spw_locked = true; spw_locked = true;
if (spw_open (read_only ? O_RDONLY : O_CREAT | O_RDWR) == 0) { if (spw_open (read_only ? O_RDONLY : O_RDWR) == 0) {
fprintf (stderr, fprintf (stderr,
_("%s: cannot open %s\n"), _("%s: cannot open %s\n"),
Prog, spw_dbname ()); Prog, spw_dbname ());