emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* lib/nscd.c: Include defines.h.

Browse Source 
* lib/nscd.c: Always warn when the nscd cache cannot be flushed.
	* lib/nscd.c: Avoid assignments in comparisons.
	* lib/nscd.c: Ignore the return value of fputs() when printing
	errors.
This commit is contained in:
nekral-guest 2008-06-10 20:01:55 +00:00
parent 269d4c55dd
commit ef1a2a82dd
2 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2008-06-10 Nicolas François <nicolas.francois@centraliens.net>
* lib/nscd.c: Include defines.h.
* lib/nscd.c: Always warn when the nscd cache cannot be flushed.
* lib/nscd.c: Avoid assignments in comparisons.
* lib/nscd.c: Ignore the return value of fputs() when printing
errors.
2008-06-10 Nicolas François <nicolas.francois@centraliens.net> 2008-06-10 Nicolas François <nicolas.francois@centraliens.net>
* lib/port.c: Add brackets and parenthesis. * lib/port.c: Add brackets and parenthesis.

17
lib/nscd.c
View File

@ -11,8 +11,11 @@
#include <errno.h> #include <errno.h>
#include <sys/wait.h> #include <sys/wait.h>
#include <sys/types.h> #include <sys/types.h>
#include "defines.h"
#include "nscd.h" #include "nscd.h"
#define MSG_NSCD_FLUSH_CACHE_FAILED "Failed to flush the nscd cache.\n"
/* /*
* nscd_flush_cache - flush specified service buffer in nscd cache * nscd_flush_cache - flush specified service buffer in nscd cache
*/ */
@ -24,23 +27,27 @@ int nscd_flush_cache (const char *service)
char *spawnedEnv[] = {NULL}; char *spawnedEnv[] = {NULL};
/* spawn process */ /* spawn process */
if( (err=posix_spawn(&pid, spawnedArgs[0], NULL, NULL, err = posix_spawn(&pid, spawnedArgs[0], NULL, NULL,
spawnedArgs, spawnedEnv)) !=0 ) spawnedArgs, spawnedEnv);
if(0 != err)
{ {
fprintf(stderr, "posix_spawn() error=%d\n", err); (void) fputs (_(MSG_NSCD_FLUSH_CACHE_FAILED), stderr);
(void) fprintf (stderr, "posix_spawn() error=%d\n", err);
return -1; return -1;
} }
/* Wait for the spawned process to exit */ /* Wait for the spawned process to exit */
termpid = TEMP_FAILURE_RETRY (waitpid (pid, &status, 0)); termpid = TEMP_FAILURE_RETRY (waitpid (pid, &status, 0));
if (termpid == -1) if (-1 == termpid)
{ {
(void) fputs (_(MSG_NSCD_FLUSH_CACHE_FAILED), stderr);
perror("waitpid"); perror("waitpid");
return -1; return -1;
} }
else if (termpid != pid) else if (termpid != pid)
{ {
fprintf(stderr, "waitpid returned %ld != %ld\n", (void) fputs (_(MSG_NSCD_FLUSH_CACHE_FAILED), stderr);
(void) fprintf (stderr, "waitpid returned %ld != %ld\n",
(long int) termpid, (long int) pid); (long int) termpid, (long int) pid);
return -1; return -1;
} }