Use safer allocation macros
Use of these macros, apart from the benefits mentioned in the commit that adds the macros, has some other good side effects: - Consistency in getting the size of the object from sizeof(type), instead of a mix of sizeof(type) sometimes and sizeof(*p) other times. - More readable code: no casts, and no sizeof(), so also shorter lines that we don't need to cut. - Consistency in using array allocation calls for allocations of arrays of objects, even when the object size is 1. Cc: Valentin V. Bartenev <vbartenev@gmail.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
committed by
Serge Hallyn
parent
6e58c12752
commit
efbbcade43
@@ -14,6 +14,8 @@
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
#include <security/pam_appl.h>
|
||||
|
||||
#include "alloc.h"
|
||||
#include "prototypes.h"
|
||||
#include "shadowlog.h"
|
||||
|
||||
@@ -43,7 +45,7 @@ static int ni_conv (int num_msg,
|
||||
return PAM_CONV_ERR;
|
||||
}
|
||||
|
||||
responses = (struct pam_response *) calloc (num_msg, sizeof (*responses));
|
||||
responses = CALLOC (num_msg, struct pam_response);
|
||||
if (NULL == responses) {
|
||||
return PAM_CONV_ERR;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user