nekral-guest
1d76eb6ef7
Avoid assignments in conditionals.
2008-01-01 22:21:55 +00:00
nekral-guest
631fa3b4f3
(split_groups): Test the pointer returned by malloc.
2008-01-01 20:47:31 +00:00
nekral-guest
6f45325d6e
Document add_one_entry_nis(), write_all(), commonio_remove(),
...
commonio_locate(), and commonio_rewind().
2008-01-01 20:34:47 +00:00
nekral-guest
4c2f65d7d0
Avoid implicit conversions to booleans.
2008-01-01 18:27:40 +00:00
nekral-guest
92d8cbb26c
Avoid implicit brackets.
2008-01-01 18:04:46 +00:00
nekral-guest
a9ae2a8710
Avoid implicit conversions to booleans.
2008-01-01 17:51:54 +00:00
nekral-guest
27ed5ec8b9
Avoid implicit brackets.
2008-01-01 16:54:18 +00:00
nekral-guest
1c2f4f0428
No functional changes were introduced by the previous pwck and grpck
...
changes, except for the following bug fix: no syslog logging if a passwd
or group file was specified on the command line without a shadowed
database file, even if the system shadowed database was changed).
2008-01-01 16:36:06 +00:00
nekral-guest
6ac97a708c
Fix typos in comments (gshadow/shadow).
2008-01-01 16:25:57 +00:00
nekral-guest
3ad9a439d5
Split also check_pw_file() and check_spw_file() out of main().
2008-01-01 15:49:33 +00:00
nekral-guest
ef2c12e560
Also split open_files and close_files out of main().
...
New global variables use_system_pw_file and use_system_spw_file
2008-01-01 15:29:47 +00:00
nekral-guest
6912ac253a
Split process_flags() out of main(). New global variables is_shadow,
...
sort_mode.
2008-01-01 15:07:41 +00:00
nekral-guest
a3501dfd95
De-comment code (duplicate the entry when the _R function is not present on the system).
2008-01-01 14:48:04 +00:00
nekral-guest
09a95ed70a
* src/lastlog.c: Remove statbuf, not used.
...
* src/lastlog.c: Fix types, cast umin and umax to uid_t.
* src/lastlog.c: (option -u) user needs to be a signed long, not
uid_t (to accept rangees like -<uid>
2008-01-01 14:38:47 +00:00
nekral-guest
d0de685c7a
Avoid ?: construct without the middle term.
2008-01-01 14:34:07 +00:00
nekral-guest
b681e50ff2
* libmisc/copydir.c, src/usermod.c, lib/prototypes.h: The uid and
...
gid parameters can be set to -1 to indicate that the original
owners must be kept. Change the types from uid_t/gid_t to a
long int (signed).
* libmisc/copydir.c: Change the copy_entry(), copy_dir(),
copy_symlink(), copy_special(), and copy_file() prototypes
accordingly.
* lib/prototypes.h: Add the parameters' name for the
libmisc/copydir.c functions.
2008-01-01 14:31:00 +00:00
nekral-guest
bb8af02978
Avoid empty file when WITH_AUDIT is not set.
2008-01-01 14:20:36 +00:00
nekral-guest
bca732693b
* libmisc/limits.c, libmisc/obscure.c, src/login_nopam.c,
...
lib/pwauth.c: Avoid empty file when USE_PAM is set.
* src/login_nopam.c: Fix warnings: resolve_hostname takes and
returns a constant string.
2008-01-01 14:18:55 +00:00
nekral-guest
0aaddfaf29
I forgot to mention compare_members_lists().
2008-01-01 14:09:47 +00:00
nekral-guest
3d82d5e452
Split check_members() out of check_grp_file() and check_sgr_file().
2008-01-01 13:50:06 +00:00
nekral-guest
612820cb9a
Split check_grp_file() and check_sgr_file() out of main().
2008-01-01 13:48:49 +00:00
nekral-guest
f6f6eeda8e
Split process_flags(), open_files(), and close_files() out of main(). New
...
global variables is_shadow, sort_mode, use_system_grp_file, and
use_system_sgr_file.
2008-01-01 13:13:47 +00:00
nekral-guest
83b9a376a2
If remove-potcdate.sin does not exist, use the one from teh po directory
...
(it is not installed automatically by autopoint.
2007-12-31 20:16:46 +00:00
nekral-guest
b9a00ea0ee
Fix the type of the bitfields in the commonio_entry and commonio_db
...
structures to unsigned int (instead of int).
2007-12-31 20:12:48 +00:00
nekral-guest
4c9686df0c
Avoid assignments in comparisons.
2007-12-31 15:30:29 +00:00
nekral-guest
ce4e74c1b9
Avoid implicit brackets.
2007-12-31 15:27:23 +00:00
nekral-guest
ca035a53a0
Also split update_shell() out of main().
2007-12-31 15:06:22 +00:00
nekral-guest
f031095d9f
* Split also check_perms() out of main().
...
* Before pam_end(), the return value of the previous
pam API was already checked. No need to validate it again.
2007-12-31 14:54:46 +00:00
nekral-guest
7ed7e14dee
Split process_flags() out of main().
2007-12-31 14:52:52 +00:00
nekral-guest
ce3c44b0f7
Avoid assignments in comparisons.
2007-12-31 14:25:06 +00:00
nekral-guest
c086f6c931
Avoid implicit conversions to booleans.
2007-12-31 14:15:29 +00:00
nekral-guest
ca468cb988
Document may_change_field().
2007-12-31 14:03:14 +00:00
nekral-guest
3d04ff4037
Avoid implicit brackets.
2007-12-31 13:48:48 +00:00
nekral-guest
7279ff37f3
* New function: process_flags() split out of main().
...
The flags variables are now global.
* New functions: check_perms(), update_gecos(),
get_old_fields(), and check_fields() split out of main().
* Before pam_end(), the return value of the previous
pam API was already checked. No need to validate it again.
2007-12-31 13:43:04 +00:00
nekral-guest
d0b984528a
* src/newusers.c: Compilation fix for PAM support (pamh needs to be
...
global since the function split).
* src/chpasswd.c: Likewise.
* src/chgpasswd.c: Likewise.
* src/chpasswd.c: Avoid implicit conversions to booleans.
2007-12-31 04:57:54 +00:00
nekral-guest
f09b1404eb
Rewrote to match the previous commit message.
2007-12-31 04:31:28 +00:00
nekral-guest
db38d0b104
* src/chage.c: Fix typo: s/maximim/maximum/
...
* src/chage.c: New function: fail_exit(). Change most of the exit()
to a fail_exit, which makes sure the files are unlocked (new global
variables: pw_locked, spw_locked), the PAM transaction is ended, and
the failure is logged to libaudit (use a global user_name and user_uid
for logging).
* src/chage.c: Compilation fix for PAM support (pamh needs to be
global since the function split).
* src/chage.c: Document process_flags(), check_flags(), check_perms(),
open_files(), and close_files().
* src/chage.c: Split update_age() and get_defaults() out of main()
* src/chage.c: Drop the privileges just after opening the files.
* src/chage.c: Do not log to audit only if the user has an entry in
the shadow file.
* NEWS, src/chage.c (open_files): Also open the password file for
writing. This fix chage when the user only has a password entry (and
no shadow entries).
* src/chage.c (get_defaults): Use default values that don't change the
behavior of the account for the fields that are not specified when the
user has no shadow entry.
2007-12-31 04:29:30 +00:00
nekral-guest
3b7497b063
* Compilation fix for PAM support (pamh needs to be
...
global since the function split).
* End the PAM transaction in fail_exit().
* Document check_flags().
2007-12-30 21:48:55 +00:00
nekral-guest
d1bee8b593
Compilation fix for non-gshadow support.
2007-12-30 21:39:57 +00:00
nekral-guest
623010396c
Added support for gshadow.
2007-12-29 17:26:28 +00:00
nekral-guest
098173e1df
Do not add the new user to the group's members, because the group is already
...
the primary group of the new user.
2007-12-29 17:05:13 +00:00
nekral-guest
67b9c423fe
Avoid variables with the name of a type.
2007-12-29 14:52:35 +00:00
nekral-guest
b040f047fd
Avoid assignments in comparisons.
2007-12-29 14:48:33 +00:00
nekral-guest
8c4efbb8ce
Avoid implicit brackets and re-indent.
2007-12-29 14:34:39 +00:00
nekral-guest
9923513271
Before pam_end(), the return value of the previous
...
pam API was already checked. No need to validate it again.
2007-12-29 14:17:06 +00:00
nekral-guest
60a422b284
newusers cleanups
...
main() split in new functions: process_flags(), check_flags(), check_perms(),
open_files(), and close_files().
2007-12-29 14:11:54 +00:00
nekral-guest
3c890a55d8
Avoid assignments in comparisons.
2007-12-29 11:34:31 +00:00
nekral-guest
a7cbfedc85
* Avoid implicit brackets.
...
* Avoid implicit conversion to booleans.
2007-12-29 11:06:35 +00:00
nekral-guest
2d771a97b7
Remove dead code. It was probably put here to add more
...
information to the audit_logger.
2007-12-29 10:50:03 +00:00
nekral-guest
6ca79a36b0
Avoid using a variable with the same name as a type.
2007-12-29 10:47:04 +00:00