nekral-guest
d0b984528a
* src/newusers.c: Compilation fix for PAM support (pamh needs to be
...
global since the function split).
* src/chpasswd.c: Likewise.
* src/chgpasswd.c: Likewise.
* src/chpasswd.c: Avoid implicit conversions to booleans.
2007-12-31 04:57:54 +00:00
nekral-guest
e448d1acb1
Sort the tools in the NEWS entries of 4.1.1.
2007-12-31 04:34:10 +00:00
nekral-guest
f09b1404eb
Rewrote to match the previous commit message.
2007-12-31 04:31:28 +00:00
nekral-guest
db38d0b104
* src/chage.c: Fix typo: s/maximim/maximum/
...
* src/chage.c: New function: fail_exit(). Change most of the exit()
to a fail_exit, which makes sure the files are unlocked (new global
variables: pw_locked, spw_locked), the PAM transaction is ended, and
the failure is logged to libaudit (use a global user_name and user_uid
for logging).
* src/chage.c: Compilation fix for PAM support (pamh needs to be
global since the function split).
* src/chage.c: Document process_flags(), check_flags(), check_perms(),
open_files(), and close_files().
* src/chage.c: Split update_age() and get_defaults() out of main()
* src/chage.c: Drop the privileges just after opening the files.
* src/chage.c: Do not log to audit only if the user has an entry in
the shadow file.
* NEWS, src/chage.c (open_files): Also open the password file for
writing. This fix chage when the user only has a password entry (and
no shadow entries).
* src/chage.c (get_defaults): Use default values that don't change the
behavior of the account for the fields that are not specified when the
user has no shadow entry.
2007-12-31 04:29:30 +00:00
nekral-guest
3b7497b063
* Compilation fix for PAM support (pamh needs to be
...
global since the function split).
* End the PAM transaction in fail_exit().
* Document check_flags().
2007-12-30 21:48:55 +00:00
nekral-guest
d1bee8b593
Compilation fix for non-gshadow support.
2007-12-30 21:39:57 +00:00
nekral-guest
99230a30ad
I forgot to open and close gshadow.
2007-12-29 17:34:02 +00:00
nekral-guest
623010396c
Added support for gshadow.
2007-12-29 17:26:28 +00:00
nekral-guest
098173e1df
Do not add the new user to the group's members, because the group is already
...
the primary group of the new user.
2007-12-29 17:05:13 +00:00
nekral-guest
67b9c423fe
Avoid variables with the name of a type.
2007-12-29 14:52:35 +00:00
nekral-guest
b040f047fd
Avoid assignments in comparisons.
2007-12-29 14:48:33 +00:00
nekral-guest
8c4efbb8ce
Avoid implicit brackets and re-indent.
2007-12-29 14:34:39 +00:00
nekral-guest
9923513271
Before pam_end(), the return value of the previous
...
pam API was already checked. No need to validate it again.
2007-12-29 14:17:06 +00:00
nekral-guest
60a422b284
newusers cleanups
...
main() split in new functions: process_flags(), check_flags(), check_perms(),
open_files(), and close_files().
2007-12-29 14:11:54 +00:00
nekral-guest
3c890a55d8
Avoid assignments in comparisons.
2007-12-29 11:34:31 +00:00
nekral-guest
37ccc0a3d4
Re-indent.
2007-12-29 11:19:39 +00:00
nekral-guest
a7cbfedc85
* Avoid implicit brackets.
...
* Avoid implicit conversion to booleans.
2007-12-29 11:06:35 +00:00
nekral-guest
2d771a97b7
Remove dead code. It was probably put here to add more
...
information to the audit_logger.
2007-12-29 10:50:03 +00:00
nekral-guest
6ca79a36b0
Avoid using a variable with the same name as a type.
2007-12-29 10:47:04 +00:00
nekral-guest
388dcee3e4
chage cleanups
...
* src/chage.c: Before pam_end(), the return value of the previous
pam API was already checked. No need to validate it again.
* src/chage.c: main() split in new functions: process_flags(),
check_flags(), check_perms(), open_files(), and close_files().
2007-12-29 10:42:25 +00:00
nekral-guest
8563319b8b
* src/chgpasswd.c: Avoid assignments in comparisons.
...
* src/chgpasswd.c: Avoid implicit brackets.
* src/chgpasswd.c: Fix comments to match chgpasswd (group instead of
user's passwords are changed).
Fix the previous ChangeLog entries regarding chgpasswd.
2007-12-28 23:14:59 +00:00
nekral-guest
9fe450e216
Same changes as for chpasswd:
...
* src/chpasswd.c: main() split in process_flags(), check_flags(),
check_perms(), open_files(), and close_files().
2007-12-28 22:59:17 +00:00
nekral-guest
28cd038c35
Same changes as for chpasswd:
...
* src/chpasswd.c: main() split in process_flags(), check_flags(),
check_perms(), open_files(), and close_files().
2007-12-28 22:54:35 +00:00
nekral-guest
8dc959ea1f
Avoid implicit brackets.
2007-12-28 22:34:14 +00:00
nekral-guest
f54464bcf6
Re-indent.
2007-12-28 22:31:45 +00:00
nekral-guest
05651a338e
Re-indent.
2007-12-28 22:30:02 +00:00
nekral-guest
908e2cbcc7
Avoid assignments in comparisons.
2007-12-28 22:24:02 +00:00
nekral-guest
b9eec1ea49
Other new functions: open_files(), close_files().
...
This force flushing the password database after the password file is unlocked.
2007-12-28 22:18:55 +00:00
nekral-guest
566b357f99
New functions: process_flags(), check_flags(),
...
check_perms(). Split out of main().
2007-12-28 22:05:51 +00:00
nekral-guest
dc1dccd9e2
Before pam_end(), the return value of the previous
...
pam API was already checked. No need to validate it again.
2007-12-28 21:29:06 +00:00
nekral-guest
8dc4ca297c
New function check_flags(). Split the validation of
...
options and arguments out of process_flags.
2007-12-28 21:04:04 +00:00
nekral-guest
605a338216
(main, check_perms): New function check_perms().
...
Split the validation of the user's permissions out of main()
2007-12-28 20:46:24 +00:00
nekral-guest
6d09b4ce4d
(main): Before pam_end(), the return value of the previous pam API was already
...
checked. No need to validate it again.
2007-12-28 20:40:59 +00:00
nekral-guest
147c37789a
Re-indent.
2007-12-28 20:35:05 +00:00
nekral-guest
ffa34c5afd
(process_flags): prefer fail_exit to exit. This avoid
...
an explicit call to audit_logger().
2007-12-28 19:15:14 +00:00
nekral-guest
da37da30e1
I forgot the initialization of group_id in find_new_gid().
2007-12-28 19:08:33 +00:00
nekral-guest
b4f6b853f8
* process_args renamed process_flags
...
* Add the options checks in process_flags (group_name, group ID uniqueness)
* Add the parameters' names in the prototypes.
2007-12-28 11:22:27 +00:00
nekral-guest
cc1f6c10be
Split the processing of options out of main().
2007-12-28 10:41:22 +00:00
nekral-guest
08e09354b2
find_new_gid is never called when an
...
GID is specified with -g. Simplify find_new_gid accordingly.
2007-12-28 10:30:39 +00:00
nekral-guest
0b6b9fe090
typo cleared/clearer
2007-12-28 10:20:02 +00:00
nekral-guest
83b546beef
(find_new_gid): If oflg is set, gflg is also set.
...
Use (!gflg), which is cleared than (!gflg || !oflg).
2007-12-28 10:19:21 +00:00
nekral-guest
b4071939e0
A group with the specified name cannot exist at that time in find_new_gid.
...
Remove the check.
2007-12-28 10:15:42 +00:00
nekral-guest
0a4424ef00
Avoid implict brackets.
2007-12-28 10:12:09 +00:00
nekral-guest
18a654d13b
When compiled without AUDIT support, if the return code was E_SUCCESS,
...
fail_exit() wouldn't have exited. Fix the scope of #idef WITH_AUDIT.
2007-12-28 09:39:22 +00:00
nekral-guest
b8650378c1
Document the new functions.
2007-12-28 00:35:41 +00:00
nekral-guest
9a9a9c0414
Other cleanups and documentation.
...
Do the checks, then build the filenames. Do not mix both.
2007-12-28 00:23:33 +00:00
nekral-guest
523392dc0b
Stop at the first error.
2007-12-28 00:08:16 +00:00
nekral-guest
ed1dd1bb99
Avoid assignement in comparison.
2007-12-28 00:04:46 +00:00
nekral-guest
6987e6f12a
Avoid implicit conversions to booleans.
2007-12-28 00:03:26 +00:00
nekral-guest
9c79c77de4
Avoid implicit casts.
2007-12-27 23:41:36 +00:00