nekral-guest
46466a8fcc
* src/login_nopam.c: Do not use the YES and NO macros. Use the
...
booleans true and false instead. Change the prototypes of
list_match(), user_match(), from_match(), and string_match()
accordingly. Also use booleans internally.
* src/login_nopam.c: Add brackets and parenthesis.
* src/login_nopam.c: Avoid implicit conversion of pointers /
integers / chars to booleans.
* src/login_nopam.c: Avoid assignments in comparisons.
2008-06-09 18:35:32 +00:00
nekral-guest
4e0d734598
* src/newgrp.c: Use a bool for is_newgrp, notfound, needspasswd,
...
initflag, and cflag.
* src/newgrp.c: Add brackets and parenthesis.
* src/newgrp.c: Avoid implicit conversion of pointers / integers /
chars to booleans.
* src/newgrp.c: Avoid multi-statements lines.
* src/newgrp.c: Ignore return value of setlocale(),
bindtextdomain(), and textdomain().
* src/newgrp.c: Avoid assignments in comparisons.
2008-06-09 18:23:23 +00:00
nekral-guest
8cfe8db1fb
* libmisc/list.c: Change is_on_list() prototype to return a bool.
2008-06-09 18:13:52 +00:00
nekral-guest
5ae74603da
* libmisc/find_new_ids.c: Change find_new_uid() and find_new_gid()
...
prototypes to use a bool for their first argument (sys_user /
sys_group).
2008-06-09 18:13:09 +00:00
nekral-guest
747664ad4f
* libmisc/console.c: Change is_listed() prototype to return a bool.
...
The default parameter should also be a bool.
* libmisc/console.c: Add brackets and parenthesis.
* libmisc/console.c: Avoid assignments in comparisons.
* libmisc/console.c: Change console() prototype to return a bool.
2008-06-09 18:11:20 +00:00
nekral-guest
9e31065b5e
* lib/sgetspent.c: Add brackets and parenthesis.
...
* lib/sgetspent.c: Avoid assignments in comparisons.
* lib/sgetspent.c: Avoid implicit conversion of pointers / chars to booleans.
* lib/sgetspent.c: Avoid multi-statements lines.
2008-05-26 09:39:29 +00:00
nekral-guest
004fb5f9c2
Avoid assignments in comparisons.
...
Add note about possible bug.
2008-05-26 09:22:44 +00:00
nekral-guest
da62edb4e0
Do not check twice if fields[2] and fields[3] are not empty.
2008-05-26 09:17:17 +00:00
nekral-guest
adc4729ffa
* lib/sgetpwent.c: Avoid implicit conversion of pointers / chars to booleans.
...
* lib/sgetpwent.c: Add brackets and parenthesis.
* lib/sgetpwent.c: Return NULL instead of 0.
2008-05-26 09:15:02 +00:00
nekral-guest
94b414861d
* libmisc/getdate.y: abbrev is a bool.
...
* libmisc/getdate.y: Avoid implicit conversion of pointers / chars / integers to booleans.
2008-05-26 08:59:54 +00:00
nekral-guest
9305161183
* lib/prototypes.h: Fix prototypes according to earlier changes (usage of the bool type).
...
* lib/prototypes.h: Add the arguments' name to the prototypes.
2008-05-26 08:56:34 +00:00
nekral-guest
297fa24b90
Add protection against multiple inclusions.
2008-05-26 08:53:56 +00:00
nekral-guest
4f38c8d201
The changed, isopen, locked, and readonly fields of the db are booleans.
2008-05-26 08:51:45 +00:00
nekral-guest
964f68630a
* lib/pwio.h: Add protection against multiple inclusions.
...
* lib/pwio.c: The changed, isopen, locked, and readonly fields of the db are booleans.
2008-05-26 08:49:44 +00:00
nekral-guest
77020623ed
* lib/shadowio.h, lib/shadowio.c: spw_file_present returns a bool.
...
* lib/shadowio.h: Add protection against multiple inclusions.
2008-05-26 08:45:34 +00:00
nekral-guest
d264017684
* lib/sgroupio.c: Avoid assignments in comparisons.
...
* lib/sgroupio.c: Add brackets.
* lib/sgroupio.c: Avoid implicit conversion of pointers / integers to booleans.
* lib/sgroupio.c: The changed, isopen, locked, and readonly fields of the db are booleans.
* lib/sgroupio.h, lib/sgroupio.c: sgr_file_present returns a bool.
* lib/sgroupio.h: Add protection against multiple inclusions.
2008-05-26 08:43:50 +00:00
nekral-guest
383ea561f8
* lib/gshadow.c: nis_used and nis_bound are booleans.
...
* lib/gshadow.c: Avoid implicit conversion of pointers / integers to booleans.
* lib/gshadow.c: Avoid assignments in comparisons.
* lib/gshadow.c: Add brackets.
2008-05-26 08:40:04 +00:00
nekral-guest
ef5e803875
Add protection against multiple inclusion
2008-05-26 08:35:13 +00:00
nekral-guest
22de221c21
The changed, isopen, locked, and readonly fields of the db are booleans.
2008-05-26 08:34:04 +00:00
nekral-guest
6f88bcf581
* lib/sgetgrent.c: implicit conversion of pointers / chars to booleans.
...
* lib/sgetgrent.c: Avoid assignments in comparisons.
* lib/sgetgrent.c: Add brackets.
2008-05-26 08:31:14 +00:00
nekral-guest
6ce26e12f5
* lib/encrypt.c: Avoid implicit conversion of pointers to booleans.
...
* lib/encrypt.c: Add parenthesis.
2008-05-26 01:07:13 +00:00
nekral-guest
09869159f7
* lib/port.c: Avoid implicit conversion of pointers / integers / chars to booleans.
...
* lib/port.c: Avoid multiple statement on the same line.
* lib/port.c: Add brackets and parenthesis.
* lib/port.c: Avoid assignments in comparisons.
* lib/port.c: Fix typo comparision -> comparison (in comment).
2008-05-26 01:05:04 +00:00
nekral-guest
14839257ac
* lib/fputsx.c: Add brackets.
...
* lib/fputsx.c: Avoid assignments in comparisons.
* lib/fputsx.c: Avoid implicit conversion of pointers / integers / chars to booleans.
2008-05-26 00:59:42 +00:00
nekral-guest
f16c6bd7dd
* lib/commonio.h: commonio_entry.changed, commonio_db.changed, commonio_db.isopen, commonio_db.locked, and commonio_db.readonly are no booleans.
...
* lib/commonio.h: Include defines.h to get the definition of bool.
* lib/commonio.h: commonio_present returns a bool
* lib/commonio.c: Implement above changes.
* lib/commonio.c: add argument names in prototypes.
* lib/commonio.c: name_is_nis returns a bool.
* lib/commonio.c: nscd_need_reload is a bool.
* lib/commonio.c: Improve types (use size_t / pid_t when needed instead of int).
* lib/commonio.c: Avoid assignments in comparisons.
* lib/commonio.c: Add brackets and parenthesis.
* lib/commonio.c: Avoid implicit conversion of pointers / integers to booleans
* lib/commonio.c: The return values of utime is not checked on purpose.
2008-05-26 00:46:25 +00:00
nekral-guest
fc6d8e933b
* libmisc/isexpired.c: ARGSUSED is no more needed (shadow is always supported).
...
* libmisc/isexpired.c: Avoid implicit conversion of pointers to booleans.
* libmisc/isexpired.c: Add brackets and parenthesis.
2008-05-26 00:14:10 +00:00
nekral-guest
c6364944d4
* libmisc/sulog.c (sulog): The success argument is a bool.
...
* libmisc/sulog.c: The return values of fflush is not checked on purpose.
* libmisc/sulog.c: Indicate that some return values should be checked.
2008-05-26 00:09:24 +00:00
nekral-guest
3d7aa44c8e
* libmisc/ttytype.c: Avoid implicit conversion of pointers / integers to booleans.
...
* libmisc/ttytype.c: Avoid assignments in comparisons.
* libmisc/ttytype.c: Add brackets and parenthesis.
* libmisc/ttytype.c: The return values of fclose is not checked on purpose.
2008-05-26 00:02:15 +00:00
nekral-guest
c249832df1
* libmisc/mail.c: Avoid implicit conversion of pointers to booleans.
...
* libmisc/mail.c: Avoid assignments in comparisons.
2008-05-25 23:59:05 +00:00
nekral-guest
3169455653
* libmisc/loginprompt.c: Avoid implicit conversion of pointers / chars to booleans.
...
* libmisc/loginprompt.c: Add brackets.
* libmisc/loginprompt.c: Avoid assignments in comparisons.
* libmisc/loginprompt.c: The return values of fclose and fflush are not checked on purpose.
2008-05-25 23:57:41 +00:00
nekral-guest
f7122499a6
Avoid implicit conversion of chars to booleans.
2008-05-25 23:50:03 +00:00
nekral-guest
cc7ac94641
selinux_checked, selinux_enabled, and set_orig are now booleans.
2008-05-25 23:45:21 +00:00
nekral-guest
7f9dfde0dc
* libmisc/setugid.c (setup_uid_gid): The is_console argument is now a bool.
...
* libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans.
* libmisc/setugid.c: Add brackets.
2008-05-25 23:42:39 +00:00
nekral-guest
2533c87bd6
* libmisc/setugid.c (setup_uid_gid): The is_console argument is no a bool.
...
* libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans.
* libmisc/setugid.c: Add brackets.
2008-05-25 23:39:59 +00:00
nekral-guest
6fef9f5178
* libmisc/pam_pass.c (do_pam_passwd): The silent and
...
change_expired are no booleans instead of int.
* libmisc/pam_pass.c: The return value of pam_end is not checked
on purpose.
2008-05-25 23:38:05 +00:00
nekral-guest
53bedaa4c1
* libmisc/getlong.c: Avoid implicit conversion of pointers / chars to booleans.
...
* libmisc/getlong.c: Add brackets.
2008-05-25 23:25:33 +00:00
nekral-guest
1ebf7842f5
* libmisc/valid.c: Avoid implicit conversion of pointers /chars to booleans.
...
* libmisc/valid.c: Add brackets.
2008-05-25 23:22:15 +00:00
nekral-guest
f14452ec3c
* libmisc/yesno.c: yes_or_no returns a bool instead of int.
...
* libmisc/yesno.c: Avoid implicit conversion of pointers to booleans.
* libmisc/yesno.c: The return value of fflush is not checked on purpose.
2008-05-25 23:01:14 +00:00
nekral-guest
78c0edb7c1
(failcheck): The failed argument is a bool.
2008-05-25 22:54:20 +00:00
nekral-guest
f2b4efff20
Avoid implicit conversion of integers to booleans.
2008-05-25 22:51:46 +00:00
nekral-guest
11003f5842
* libmisc/rlogin.c: Avoid assignments in comparisons.
...
* libmisc/rlogin.c: Avoid implicit conversion of integers to booleans.
* libmisc/rlogin.c: Add brackets.
2008-05-25 22:49:41 +00:00
nekral-guest
c638c3cc3d
* libmisc/failure.c (failcheck): The failed argument is a bool.
...
* libmisc/failure.c (too_many_failures): too_many_failures returns
a bool.
* libmisc/failure.c: Add notes about unchecked return values.
* libmisc/failure.c: Avoid assignments in comparisons.
* libmisc/failure.c: Add brackets.
2008-05-25 22:44:44 +00:00
nekral-guest
a2982f0d4e
* libmisc/myname.c: Avoid assignments in comparisons.
...
* libmisc/myname.c: Avoid implicit conversion of pointers / chars
to booleans.
* libmisc/myname.c: Add brackets.
2008-05-25 22:15:28 +00:00
nekral-guest
7069324a20
* libmisc/utmp.c (checkutmp): Change picky argument's type to
...
bool.
* libmisc/utmp.c: Use bool when possible (found_utmpx,
found_utmp).
* libmisc/utmp.c: Add note about unchecked return values.
2008-05-25 22:11:12 +00:00
nekral-guest
9d331bb32b
* Change type of added to bool.
...
* Avoid implicit conversion of pointers to booleans.
2008-05-25 22:03:09 +00:00
nekral-guest
bc0657d13c
* hushed returns a bool instead of int.
...
* Avoid assignments in comparisons.
* (hushed) Change type of found to bool.
* Add brackets.
* Always check if the user or the shell is in
the file. Do not check the first character of the line first. This
is simpler and match better with the HUSHLOGIN_FILE documentation.
2008-05-25 21:52:14 +00:00
nekral-guest
712ed48a62
* lib/getdef.h, lib/getdef.c: getdef_bool returns a bool instead
...
of int.
* lib/getdef.c: Change typo of def_loaded to bool.
* lib/getdef.c: Add brackets.
* lib/getdef.c: Avoid assignment in comparisons.
2008-05-25 21:43:05 +00:00
nekral-guest
b94825bbad
* is_my_tty returns a bool.
...
* Avoid implicit conversion of integers to booleans.
* Add brackets.
2008-05-25 21:33:38 +00:00
nekral-guest
06d2a32a3e
* Avoid assignment in comparisons, implicit comparison of integers to booleans.
...
* The return value of closedir is not checked on purpose.
* Add brackets.
2008-05-25 21:23:28 +00:00
nekral-guest
623d9e2ab3
* libmisc/chkname.h, libmisc/chkname.c: check_group_name (resp.
...
check_user_name) renamed to is_valid_user_name (resp.
is_valid_group_name). is_valid_user_name and is_valid_group_name
return a bool.
* src/grpck.c, src/newusers.c, src/usermod.c, src/useradd.c,
src/groupmod.c, src/pwck.c, src/groupadd.c: Use is_valid_user_name
and is_valid_group_name, following above change.
* libmisc/chkname.c: Avoid implicit conversion of chars to
booleans. Add brackets and parenthesis.
2008-05-25 20:58:16 +00:00
nekral-guest
cb8d416b37
Avoid implicit conversion of integers / pointers to booleans.
2008-05-25 20:41:13 +00:00