nekral-guest
f7122499a6
Avoid implicit conversion of chars to booleans.
2008-05-25 23:50:03 +00:00
nekral-guest
cc7ac94641
selinux_checked, selinux_enabled, and set_orig are now booleans.
2008-05-25 23:45:21 +00:00
nekral-guest
7f9dfde0dc
* libmisc/setugid.c (setup_uid_gid): The is_console argument is now a bool.
...
* libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans.
* libmisc/setugid.c: Add brackets.
2008-05-25 23:42:39 +00:00
nekral-guest
2533c87bd6
* libmisc/setugid.c (setup_uid_gid): The is_console argument is no a bool.
...
* libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans.
* libmisc/setugid.c: Add brackets.
2008-05-25 23:39:59 +00:00
nekral-guest
6fef9f5178
* libmisc/pam_pass.c (do_pam_passwd): The silent and
...
change_expired are no booleans instead of int.
* libmisc/pam_pass.c: The return value of pam_end is not checked
on purpose.
2008-05-25 23:38:05 +00:00
nekral-guest
f9ac07f455
Updated copyright dates.
2008-05-25 23:32:41 +00:00
nekral-guest
175e361a4d
Updated copyright dates.
2008-05-25 23:31:10 +00:00
nekral-guest
53bedaa4c1
* libmisc/getlong.c: Avoid implicit conversion of pointers / chars to booleans.
...
* libmisc/getlong.c: Add brackets.
2008-05-25 23:25:33 +00:00
nekral-guest
1ebf7842f5
* libmisc/valid.c: Avoid implicit conversion of pointers /chars to booleans.
...
* libmisc/valid.c: Add brackets.
2008-05-25 23:22:15 +00:00
nekral-guest
f14452ec3c
* libmisc/yesno.c: yes_or_no returns a bool instead of int.
...
* libmisc/yesno.c: Avoid implicit conversion of pointers to booleans.
* libmisc/yesno.c: The return value of fflush is not checked on purpose.
2008-05-25 23:01:14 +00:00
nekral-guest
78c0edb7c1
(failcheck): The failed argument is a bool.
2008-05-25 22:54:20 +00:00
nekral-guest
f2b4efff20
Avoid implicit conversion of integers to booleans.
2008-05-25 22:51:46 +00:00
nekral-guest
11003f5842
* libmisc/rlogin.c: Avoid assignments in comparisons.
...
* libmisc/rlogin.c: Avoid implicit conversion of integers to booleans.
* libmisc/rlogin.c: Add brackets.
2008-05-25 22:49:41 +00:00
nekral-guest
c638c3cc3d
* libmisc/failure.c (failcheck): The failed argument is a bool.
...
* libmisc/failure.c (too_many_failures): too_many_failures returns
a bool.
* libmisc/failure.c: Add notes about unchecked return values.
* libmisc/failure.c: Avoid assignments in comparisons.
* libmisc/failure.c: Add brackets.
2008-05-25 22:44:44 +00:00
nekral-guest
a2982f0d4e
* libmisc/myname.c: Avoid assignments in comparisons.
...
* libmisc/myname.c: Avoid implicit conversion of pointers / chars
to booleans.
* libmisc/myname.c: Add brackets.
2008-05-25 22:15:28 +00:00
nekral-guest
639b2bd8e5
2008-05-25 22:14:19 +00:00
nekral-guest
7069324a20
* libmisc/utmp.c (checkutmp): Change picky argument's type to
...
bool.
* libmisc/utmp.c: Use bool when possible (found_utmpx,
found_utmp).
* libmisc/utmp.c: Add note about unchecked return values.
2008-05-25 22:11:12 +00:00
nekral-guest
9d331bb32b
* Change type of added to bool.
...
* Avoid implicit conversion of pointers to booleans.
2008-05-25 22:03:09 +00:00
nekral-guest
bc0657d13c
* hushed returns a bool instead of int.
...
* Avoid assignments in comparisons.
* (hushed) Change type of found to bool.
* Add brackets.
* Always check if the user or the shell is in
the file. Do not check the first character of the line first. This
is simpler and match better with the HUSHLOGIN_FILE documentation.
2008-05-25 21:52:14 +00:00
nekral-guest
712ed48a62
* lib/getdef.h, lib/getdef.c: getdef_bool returns a bool instead
...
of int.
* lib/getdef.c: Change typo of def_loaded to bool.
* lib/getdef.c: Add brackets.
* lib/getdef.c: Avoid assignment in comparisons.
2008-05-25 21:43:05 +00:00
nekral-guest
66afec21d1
Allow usage of booleans in the source.
2008-05-25 21:34:38 +00:00
nekral-guest
b94825bbad
* is_my_tty returns a bool.
...
* Avoid implicit conversion of integers to booleans.
* Add brackets.
2008-05-25 21:33:38 +00:00
nekral-guest
06d2a32a3e
* Avoid assignment in comparisons, implicit comparison of integers to booleans.
...
* The return value of closedir is not checked on purpose.
* Add brackets.
2008-05-25 21:23:28 +00:00
nekral-guest
623d9e2ab3
* libmisc/chkname.h, libmisc/chkname.c: check_group_name (resp.
...
check_user_name) renamed to is_valid_user_name (resp.
is_valid_group_name). is_valid_user_name and is_valid_group_name
return a bool.
* src/grpck.c, src/newusers.c, src/usermod.c, src/useradd.c,
src/groupmod.c, src/pwck.c, src/groupadd.c: Use is_valid_user_name
and is_valid_group_name, following above change.
* libmisc/chkname.c: Avoid implicit conversion of chars to
booleans. Add brackets and parenthesis.
2008-05-25 20:58:16 +00:00
nekral-guest
cb8d416b37
Avoid implicit conversion of integers / pointers to booleans.
2008-05-25 20:41:13 +00:00
nekral-guest
de9bee0354
Avoid implicit conversion of integers / pointers to booleans.
2008-05-25 20:39:31 +00:00
nekral-guest
ae75a8c0c1
Allow usage of booleans in the source.
2008-05-25 20:37:51 +00:00
nekral-guest
8098f63998
Allow --disable-man and --enable-man=no.
2008-05-25 20:30:45 +00:00
nekral-guest
2303ddd0de
Set the version to 4.1.2.
2008-05-24 23:15:47 +00:00
nekral-guest
b5b636b8b7
Prepare the 4.1.2 release
...
* NEWS: set the release date.
* man/po/*.po, po/*.po: Updated PO files.
2008-05-24 23:03:24 +00:00
nekral-guest
a665e829ae
Run msgmerge with --previous. (This requires gettext >= 0.16)
2008-05-24 22:58:21 +00:00
nekral-guest
6124b59aff
* libmisc/copydir.c (remove_tree): As we always use remove_tree
...
followed by rmdir to remove the directory itself, delete also the
root directory in remove_tree.
* src/userdel.c, src/usermod.c: Do not call rmdir after
remove_tree.
2008-05-24 15:35:15 +00:00
nekral-guest
9c41a8ad38
* libmisc/fields.c: Avoid assignments in comparisons, assignments
...
with post increments (x++), use of integers as booleans, and
explicitly mark blocks with brackets.
* libmisc/copydir.c: Likewise.
* libmisc/fields.c: Add comments.
* libmisc/copydir.c: Mark function whose return value is not
checked as such.
* libmisc/copydir.c (remove_tree): Make sure unlink is successful
when removing files.
2008-05-24 15:19:02 +00:00
nekral-guest
cda1f9a23d
Simply passwd_check since it's never used when configured with PAM support.
2008-05-24 14:11:31 +00:00
nekral-guest
0219d72f48
* libmisc/list.c: Avoid assignments in comparisons, assignments
...
with post increments (x++), use of integers as booleans, and
explicitly mark blocks with brackets.
2008-05-24 14:09:35 +00:00
nekral-guest
d99423405c
Fix compiler warnings:
...
* libmisc/audit_help.c: Include prototypes.h to get the prototype
of audit_help_open.
* libmisc/salt.c: Use booleans instead of negating integers.
* src/passwd.c: Declare the check_selinux_access prototype and
avoid name clashes (change_user -> changed_user; change_uid ->
changed_uid; access -> requested_access)
2008-05-24 13:08:58 +00:00
nekral-guest
eeb9592ded
Use fputs rather than fprintf for constant strings.
2008-05-23 20:55:11 +00:00
nekral-guest
0120fc10e1
Added TODO items.
2008-05-23 20:47:45 +00:00
nekral-guest
b9ac46305f
Indicate that login should be executed with "exec login" if called from a shell.
2008-05-21 18:58:06 +00:00
nekral-guest
ec9e63b7de
Remove the advices for the choice of a good password (they are debatable). Point to http://en.wikipedia.org/wiki/Password_strength instead.
2008-05-21 18:25:48 +00:00
nekral-guest
a917ba4fb9
*** security:
...
- generation of SHA encrypted passwords (chpasswd, gpasswd, newusers,
chgpasswd; and also passwd if configured without PAM support).
The number of rounds and number of salt bytes was fixed to their lower
allowed values (resp. configurable and 8), hence voiding some of the
advantages of this encryption method. Dictionary attacks with
precomputed tables were easier than expected, but still harder than with
the MD5 (or DES) methods.
* NEWS, libmisc/salt.c (SHA_salt_size): Seed the RNG, and fix a
overflow. These caused the SHA salt size to always be 8 bytes,
instead of being in the 8-16 range. Thanks to Peter Vrabec
pvrabec@redhat.com for noticing.
* NEWS, libmisc/salt.c (SHA_salt_rounds): Seed the RNG with
seedRNG instead of srand, and fix the same overflow. This caused
the number of rounds to always be the smallest one.
2008-05-20 13:34:06 +00:00
nekral-guest
9c69fe73b1
Tag the section which require --enable-shadowgrp or --with-sha-crypt
...
accordingly.
2008-05-19 22:18:14 +00:00
nekral-guest
63228ac1c6
SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can only exist if configured with --with-sha-crypt.
2008-05-19 21:57:48 +00:00
nekral-guest
a071d72e48
Document the -k, --skel option, and update the -m, --create-home documentation.
2008-05-19 21:32:19 +00:00
nekral-guest
7ab3a97dfe
Sort options.
2008-05-19 21:04:34 +00:00
nekral-guest
ae7aeda621
SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can
...
only exist if configured with --with-sha-crypt.
2008-05-19 20:59:51 +00:00
nekral-guest
0d6b2221ab
SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can
...
only exist if configured with --with-sha-crypt.
2008-05-19 20:58:59 +00:00
nekral-guest
337a97ceab
Document the sections closed by #endif
2008-05-19 20:56:48 +00:00
nekral-guest
461d69522f
* NEWS, man/groupadd.8.xml: Document the -r, --system option.
...
* NEWS, man/newusers.8.xml: Document the -r, --system option.
* NEWS, man/newusers.8.xml: Document the -c, --crypt-method and
-s, --sha-rounds options.
2008-05-19 20:53:12 +00:00
nekral-guest
537496c019
Fix formatting.
2008-05-19 20:31:48 +00:00