emo/sysvinit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updated wall.c to make it easier to adjust buffer sizes without

Browse Source 
causing overflow or off-by-one errors.
This commit is contained in:
Jesse Smith 2019-01-27 16:04:13 -04:00
parent 483dc777d2
commit 09f8dcc90e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/wall.c
View File

@ -34,12 +34,13 @@
#define MAXLEN 4096 #define MAXLEN 4096
#define LINE_SIZE 80
#define MAXLINES 20 #define MAXLINES 20
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
char buf[MAXLEN]; char buf[MAXLEN];
char line[83]; char line[LINE_SIZE + 3]; /* leave room for \r\n\0 */
int i, f, ch; int i, f, ch;
int len = 0; int len = 0;
int remote = 0; int remote = 0;
@ -81,7 +82,7 @@ int main(int argc, char **argv)
if ((argc - optind) > 0) { if ((argc - optind) > 0) {
for(f = optind; f < argc; f++) { for(f = optind; f < argc; f++) {
len += strlen(argv[f]) + 1; len += strlen(argv[f]) + 1;
if (len >= MAXLEN-2) break; if (len >= MAXLEN-4) break;
strcat(buf, argv[f]); strcat(buf, argv[f]);
if (f < argc-1) strcat(buf, " "); if (f < argc-1) strcat(buf, " ");
} }