emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[block-cache] Remove nr_dirty_ and nr_io_pending_.

Browse Source 
Better to use the size of the relevant list.
This commit is contained in:
Joe Thornber 2017-07-24 16:08:49 +01:00
parent 467be1a69e
commit 0a06e4b21b
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
block-cache/block_cache.cc
View File

@ -105,17 +105,14 @@ block_cache::complete_io(block &b, int result)
{ {
b.error_ = result; b.error_ = result;
b.clear_flags(BF_IO_PENDING); b.clear_flags(BF_IO_PENDING);
nr_io_pending_--;
if (b.error_) { if (b.error_) {
b.unlink(); b.unlink();
errored_.push_back(b); errored_.push_back(b);
} else { } else {
if (b.test_flags(BF_DIRTY)) { if (b.test_flags(BF_DIRTY))
b.clear_flags(BF_DIRTY | BF_PREVIOUSLY_DIRTY); b.clear_flags(BF_DIRTY | BF_PREVIOUSLY_DIRTY);
nr_dirty_--;
}
b.unlink(); b.unlink();
clean_.push_back(b); clean_.push_back(b);
@ -135,7 +132,6 @@ block_cache::issue_low_level(block &b, enum io_iocb_cmd opcode, const char *desc
assert(!b.test_flags(BF_IO_PENDING)); assert(!b.test_flags(BF_IO_PENDING));
b.set_flags(BF_IO_PENDING); b.set_flags(BF_IO_PENDING);
nr_io_pending_++;
b.unlink(); b.unlink();
io_pending_.push_back(b); io_pending_.push_back(b);
@ -374,8 +370,6 @@ block_cache::calc_nr_buckets(unsigned nr_blocks)
block_cache::block_cache(int fd, sector_t block_size, uint64_t on_disk_blocks, size_t mem) block_cache::block_cache(int fd, sector_t block_size, uint64_t on_disk_blocks, size_t mem)
: nr_locked_(0), : nr_locked_(0),
nr_dirty_(0),
nr_io_pending_(0),
read_hits_(0), read_hits_(0),
read_misses_(0), read_misses_(0),
write_zeroes_(0), write_zeroes_(0),
@ -555,7 +549,7 @@ block_cache::get(block_address index, unsigned flags, validator::ptr v)
void void
block_cache::preemptive_writeback() block_cache::preemptive_writeback()
{ {
unsigned nr_available = nr_cache_blocks_ - (nr_dirty_ - nr_io_pending_); unsigned nr_available = nr_cache_blocks_ - (dirty_.size() - io_pending_.size());
if (nr_available < (WRITEBACK_LOW_THRESHOLD_PERCENT * nr_cache_blocks_ / 100)) if (nr_available < (WRITEBACK_LOW_THRESHOLD_PERCENT * nr_cache_blocks_ / 100))
writeback((WRITEBACK_HIGH_THRESHOLD_PERCENT * nr_cache_blocks_ / 100) - nr_available); writeback((WRITEBACK_HIGH_THRESHOLD_PERCENT * nr_cache_blocks_ / 100) - nr_available);
@ -575,7 +569,6 @@ block_cache::release(block_cache::block &b)
if (!b.test_flags(BF_PREVIOUSLY_DIRTY)) { if (!b.test_flags(BF_PREVIOUSLY_DIRTY)) {
b.unlink(); b.unlink();
dirty_.push_back(b); dirty_.push_back(b);
nr_dirty_++;
b.set_flags(BF_PREVIOUSLY_DIRTY); b.set_flags(BF_PREVIOUSLY_DIRTY);
} }

2
block-cache/block_cache.h
View File

@ -267,9 +267,7 @@ namespace bcache {
block_list clean_; block_list clean_;
unsigned nr_locked_; unsigned nr_locked_;
unsigned nr_dirty_;
unsigned nr_io_pending_;
block_list io_pending_; block_list io_pending_;
typedef bi::member_hook<block, typedef bi::member_hook<block,