emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[space-maps] remove count_possibly_greater_than_one

Browse Source 
This is only ever called with a recursive space map wrapper,
and that causes too many false positives.  False positives trigger
a copy of a metadata page, so this is a false economy.
This commit is contained in:
Joe Thornber
2020-05-28 07:38:58 +01:00
parent 29cfdd8979
commit 128ecc27f2
7 changed files with 1 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
persistent-data/space-maps/core.cc
View File

@ -43,7 +43,6 @@ namespace {
void inc(block_address b, ref_t count) override;
void dec(block_address b, ref_t count) override;
maybe_block find_free(span_iterator &it) override;
bool count_possibly_greater_than_one(block_address b) const override;
void extend(block_address extra_blocks) override;
void count_metadata(block_counter &bc) const override;
@ -131,11 +130,6 @@ namespace {
return maybe_block();
}
bool
core_map::count_possibly_greater_than_one(block_address b) const {
return get_count(b) > 1;
}
void
core_map::extend(block_address extra_blocks) {
throw std::runtime_error("'extend' not implemented");