Small work on metadata_checker tests.

thin-provisioning/superblock_validator.cc

@@ -11,7 +11,7 @@ namespace {
         unsigned const SECTOR_TO_BLOCK_SHIFT = 3;
 	uint32_t const SUPERBLOCK_CSUM_SEED = 160774;
 
-	struct validator : public block_manager<>::validator {
+	struct sb_validator : public block_manager<>::validator {
 		virtual void check(buffer<> const &b, block_address location) const {
 			superblock_disk const *sbd = reinterpret_cast<superblock_disk const *>(&b);
 			crc32c sum(SUPERBLOCK_CSUM_SEED);
@@ -34,7 +34,7 @@ namespace {
 block_manager<>::validator::ptr
 thin_provisioning::superblock_validator()
 {
-	return block_manager<>::validator::ptr(new validator);
+	return block_manager<>::validator::ptr(new sb_validator);
 }
 
 //----------------------------------------------------------------

unit-tests/Makefile.in

@@ -40,6 +40,7 @@ lib/libgmock.a: $(GMOCK_DEPS)
 
 TEST_SOURCE=\
 	unit-tests/gmock_main.cc \
+	unit-tests/test_utils.cc \
 	\
 	unit-tests/array_block_t.cc \
 	unit-tests/array_t.cc \

unit-tests/metadata_checker_t.cc

@@ -120,8 +120,7 @@ namespace {
 		}
 
 		void corrupt_superblock() {
-			block_manager<>::write_ref wr = bm_->write_lock(0);
-			wr.data()[57] = 0;
+			zero_block(bm_, SUPERBLOCK_LOCATION);
 		}
 
 		with_temp_directory dir_;

unit-tests/test_utils.cc

@@ -0,0 +1,11 @@
+#include "test_utils.h"
+
+//----------------------------------------------------------------
+
+void test::zero_block(block_manager<>::ptr bm, block_address b)
+{
+	block_manager<>::write_ref wr = bm->write_lock(b);
+	memset(&wr.data(), 0, sizeof(wr.data()));
+}
+
+//----------------------------------------------------------------

unit-tests/test_utils.h

@@ -35,6 +35,8 @@ namespace test {
 			new block_manager<BlockSize>(path, nr, MAX_HELD_LOCKS,
 						     block_io<BlockSize>::CREATE));
 	}
+
+	void zero_block(block_manager<>::ptr bm, block_address b);
 }
 
 //----------------------------------------------------------------