emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[all tools] Improve the error message if opening the metadata fails.

Browse Source 
Remind the admin that you shouldn't run the tools on live data.
This commit is contained in:
Joe Thornber 2015-08-13 12:57:07 +01:00
parent c32aaab028
commit 8fab56680c
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
persistent-data/block.tcc
View File

@ -46,14 +46,23 @@ namespace {
// to exception.h // to exception.h
void syscall_failed(char const *call) { void syscall_failed(char const *call) {
ostringstream out; ostringstream out;
out << "syscall '" << call << "' failed: " << base::error_string(errno);; out << "syscall '" << call << "' failed: " << base::error_string(errno);
throw runtime_error(out.str());
}
void syscall_failed(string const &call, string const &message)
{
ostringstream out;
out << "syscall '" << call << "' failed: " << base::error_string(errno) << "\n"
<< message;
throw runtime_error(out.str()); throw runtime_error(out.str());
} }
int open_file(string const &path, int flags) { int open_file(string const &path, int flags) {
int fd = ::open(path.c_str(), OPEN_FLAGS | flags, DEFAULT_MODE); int fd = ::open(path.c_str(), OPEN_FLAGS | flags, DEFAULT_MODE);
if (fd < 0) if (fd < 0)
syscall_failed("open"); syscall_failed("open",
"Note: you cannot run this tool with these options on live metadata.");
return fd; return fd;
} }