emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[thin/metadata_dumper] Change a couple of confusing class names.

Browse Source 
metadata_emitter is actually a visitor that passes on it's data
to an encapsulated emitter object.

metadata_emitter -> metadata_emit_visitor
metadata_tree_emitter -> metadata_tree_emit_visitor
This commit is contained in:
Joe Thornber 2019-06-03 11:07:32 +01:00
parent a13178ffd1
commit e45a211902
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
thin-provisioning/metadata_dumper.cc
View File

@ -608,14 +608,14 @@ namespace {
//---------------------------------------------------------------- //----------------------------------------------------------------
namespace { namespace {
class mapping_emitter : public mapping_tree_detail::mapping_visitor { class mapping_emit_visitor : public mapping_tree_detail::mapping_visitor {
public: public:
mapping_emitter(emitter::ptr e) mapping_emit_visitor(emitter::ptr e)
: e_(e), : e_(e),
in_range_(false) { in_range_(false) {
} }
~mapping_emitter() { ~mapping_emit_visitor() {
end_mapping(); end_mapping();
} }
@ -667,9 +667,9 @@ namespace {
bool in_range_; bool in_range_;
}; };
class mapping_tree_emitter : public mapping_tree_detail::device_visitor { class mapping_tree_emit_visitor : public mapping_tree_detail::device_visitor {
public: public:
mapping_tree_emitter(dump_options const &opts, mapping_tree_emit_visitor(dump_options const &opts,
metadata::ptr md, metadata::ptr md,
emitter::ptr e, emitter::ptr e,
dd_map const &dd, dd_map const &dd,
@ -716,7 +716,7 @@ namespace {
private: private:
void emit_mappings(uint64_t dev_id, block_address subtree_root) { void emit_mappings(uint64_t dev_id, block_address subtree_root) {
mapping_emitter me(e_); mapping_emit_visitor me(e_);
single_mapping_tree tree(*md_->tm_, subtree_root, single_mapping_tree tree(*md_->tm_, subtree_root,
mapping_tree_detail::block_time_ref_counter(md_->data_sm_)); mapping_tree_detail::block_time_ref_counter(md_->data_sm_));
walk_mapping_tree(tree, dev_id, static_cast<mapping_tree_detail::mapping_visitor &>(me), *damage_policy_); walk_mapping_tree(tree, dev_id, static_cast<mapping_tree_detail::mapping_visitor &>(me), *damage_policy_);
@ -792,7 +792,7 @@ namespace {
{ {
mapping_tree_detail::damage_visitor::ptr md_policy(mapping_damage_policy(true)); mapping_tree_detail::damage_visitor::ptr md_policy(mapping_damage_policy(true));
mapping_tree_emitter mte(opts, md, e, de.get_details(), mapping_damage_policy(true)); mapping_tree_emit_visitor mte(opts, md, e, de.get_details(), mapping_damage_policy(true));
walk_mapping_tree(*md->mappings_top_level_, mte, *md_policy); walk_mapping_tree(*md->mappings_top_level_, mte, *md_policy);
} }
@ -819,7 +819,7 @@ thin_provisioning::metadata_dump(metadata::ptr md, emitter::ptr e, dump_options
{ {
mapping_tree_detail::damage_visitor::ptr md_policy(mapping_damage_policy(false)); mapping_tree_detail::damage_visitor::ptr md_policy(mapping_damage_policy(false));
mapping_tree_emitter mte(opts, md, e, de.get_details(), mapping_damage_policy(false)); mapping_tree_emit_visitor mte(opts, md, e, de.get_details(), mapping_damage_policy(false));
walk_mapping_tree(*md->mappings_top_level_, mte, *md_policy); walk_mapping_tree(*md->mappings_top_level_, mte, *md_policy);
} }
@ -846,7 +846,7 @@ thin_provisioning::metadata_repair(block_manager<>::ptr bm, emitter::ptr e)
void void
thin_provisioning::metadata_dump_subtree(metadata::ptr md, emitter::ptr e, bool repair, uint64_t subtree_root) { thin_provisioning::metadata_dump_subtree(metadata::ptr md, emitter::ptr e, bool repair, uint64_t subtree_root) {
mapping_emitter me(e); mapping_emit_visitor me(e);
single_mapping_tree tree(*md->tm_, subtree_root, single_mapping_tree tree(*md->tm_, subtree_root,
mapping_tree_detail::block_time_ref_counter(md->data_sm_)); mapping_tree_detail::block_time_ref_counter(md->data_sm_));
// FIXME: pass the current device id instead of zero // FIXME: pass the current device id instead of zero