emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[thin_ll_dump] Fix potential segfault while reading invalid subtree roots

Browse Source
This commit is contained in:
Ming-Hung Tsai 2021-10-12 23:19:00 +08:00
parent e5f0acd288
commit f3c2ade90a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
thin-provisioning/thin_ll_dump.cc
View File

@ -135,7 +135,9 @@ namespace {
public: public:
ll_mapping_tree_emitter(block_manager::ptr bm, ll_mapping_tree_emitter(block_manager::ptr bm,
indented_stream &out) indented_stream &out)
: bm_(bm), out_(out) { : bm_(bm),
nv_(create_btree_node_validator()),
out_(out) {
} }
void visit(btree_path const &path, block_address tree_root) { void visit(btree_path const &path, block_address tree_root) {
@ -147,6 +149,7 @@ namespace {
try { try {
block_manager::read_ref rr = bm_->read_lock(tree_root); block_manager::read_ref rr = bm_->read_lock(tree_root);
node_ref<uint64_traits> n = btree_detail::to_node<uint64_traits>(rr); node_ref<uint64_traits> n = btree_detail::to_node<uint64_traits>(rr);
nv_->check(n.raw(), tree_root);
node_info ni; node_info ni;
convert_to_node_info(n, ni); convert_to_node_info(n, ni);
output_node_info(out_, ni); output_node_info(out_, ni);
@ -160,6 +163,7 @@ namespace {
} }
private: private:
block_manager::ptr bm_; block_manager::ptr bm_;
bcache::validator::ptr nv_;
indented_stream& out_; indented_stream& out_;
}; };