emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

alternatives: do not ignore symlink(2) return value.

Browse Source 
This fixes the travisci warning seen with gcc.
This commit is contained in:
Juan RP
2015-10-19 17:11:34 +02:00
parent 240d87af92
commit 4e446968c5
1 changed files with 9 additions and 1 deletions

10
lib/package_alternatives.c

@@ -136,6 +136,7 @@ create_symlinks(struct xbps_handle *xhp, xbps_array_t a, const char *grname)
xbps_string_t str; xbps_string_t str;
char *l, *lnk; char *l, *lnk;
const char *tgt; const char *tgt;
int rv;
str = xbps_array_get(a, i); str = xbps_array_get(a, i);
l = left(xbps_string_cstring_nocopy(str)); l = left(xbps_string_cstring_nocopy(str));
@@ -146,7 +147,14 @@ create_symlinks(struct xbps_handle *xhp, xbps_array_t a, const char *grname)
xbps_set_cb_state(xhp, XBPS_STATE_ALTGROUP_LINK_ADDED, 0, NULL, xbps_set_cb_state(xhp, XBPS_STATE_ALTGROUP_LINK_ADDED, 0, NULL,
"Creating '%s' alternatives group symlink: %s -> %s", grname, l, tgt); "Creating '%s' alternatives group symlink: %s -> %s", grname, l, tgt);
unlink(lnk); unlink(lnk);
symlink(tgt, lnk); if ((rv = symlink(tgt, lnk)) != 0) {
xbps_dbg_printf(xhp, "failed to create alt symlink '%s'"
"for group '%s': %s\n", lnk, grname,
strerror(errno));
free(lnk);
free(l);
return rv;
}
free(lnk); free(lnk);
free(l); free(l);
} }